[TFLite] Fixed Densify reading implementation #24707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: CPP API
|
build_jenkins |
|
build_jenkins |
rkazants
reviewed
May 28, 2024
src/frontends/tensorflow_lite/tests/test_models/gen_scripts/generate_densify.py
Outdated
Show resolved
Hide resolved
rkazants
reviewed
May 28, 2024
| : m_shape(shape), | ||
| m_traversal_order(traversal_order), | ||
| m_block_map(block_map), | ||
| m_dim_format(dim_format), | ||
| m_data_desc(data_desc) { | ||
| m_data_desc(data_desc), |
There was a problem hiding this comment.
can you give description to SparsityInfo class? From your perspective, you should know for which cases it is needed.
It will be very helpful.
rkazants
reviewed
May 28, 2024
src/frontends/tensorflow_lite/include/openvino/frontend/tensorflow_lite/sparsity_info.hpp
Outdated
Show resolved
Hide resolved
rkazants
reviewed
May 28, 2024
| for (auto idx = indices->begin(); idx != indices->end(); ++idx) { | ||
| if (*idx <= last_idx) { | ||
| data += row_size; | ||
| U last_segment = *segments->begin(); |
There was a problem hiding this comment.
can you please elaborate a logic behind this? What is a segment, last segment, etc.?
There was a problem hiding this comment.
Maybe better to do it as a separate PR, because it will be just a comments. Let me check how many time I have.
rkazants
reviewed
May 28, 2024
rkazants
reviewed
May 28, 2024
rkazants
reviewed
May 28, 2024
rkazants
reviewed
May 28, 2024
rkazants
approved these changes
May 28, 2024
dequantize and densify layers, removed unnecessary test
…nerate_densify.py Co-authored-by: Roman Kazantsev <[email protected]>
…flow_lite/sparsity_info.hpp Co-authored-by: Roman Kazantsev <[email protected]>
Co-authored-by: Roman Kazantsev <[email protected]>
Co-authored-by: Roman Kazantsev <[email protected]>
Co-authored-by: Roman Kazantsev <[email protected]>
Co-authored-by: Roman Kazantsev <[email protected]>
allnes
pushed a commit
to allnes/openvino
that referenced
this pull request
Jun 27, 2024
### Details: - Fixed Densify reading implementation - Added test for Densify - Added test for Dequantize - Removed unnecessary model test ### Tickets: - 127943 --------- Co-authored-by: Roman Kazantsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: