Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU]The shape of the memory descriptor is considered in selectPreferPrimitiveDescriptor of Subgraph #23971

Merged
merged 24 commits into from
Sep 26, 2024
Merged

[CPU]The shape of the memory descriptor is considered in selectPreferPrimitiveDescriptor of Subgraph #23971

merged 24 commits into from
Sep 26, 2024

Conversation

xipingyan
Copy link
Contributor

@xipingyan xipingyan commented Apr 11, 2024 •
edited
Loading

Details:

  • selectPreferPrimitiveDescriptor take into account shapes of the memory descriptors, because scalar shape node's reorder has less computation
  • New logic only work for Subgraph

Tickets:

  • 137307
  • 139904

@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Apr 11, 2024
@xipingyan xipingyan marked this pull request as ready for review April 11, 2024 05:53
@xipingyan xipingyan requested review from a team as code owners April 11, 2024 05:53
@dmitry-gorokhov dmitry-gorokhov added this to the 2024.2 milestone Apr 19, 2024
@dmitry-gorokhov
Copy link
Contributor

@maxnick @EgorDuplensky Please take a look

@dmitry-gorokhov dmitry-gorokhov modified the milestones: 2024.2, 2024.3 May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jun 8, 2024
@mg-intel mg-intel removed the Stale label Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jun 26, 2024
@xipingyan xipingyan force-pushed the xp/fix_zoom_regression_to_master branch from a57ed83 to f831ffb Compare June 27, 2024 02:27
@xipingyan
I found 3 subgraph nodes after rebasing.
c022b3d 
Fix test fail bug.

Signed-off-by: xipingya <[email protected]>
@github-actions github-actions bot removed the Stale label Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jul 12, 2024
@dmitry-gorokhov dmitry-gorokhov added this to the 2024.4 milestone Aug 15, 2024
EgorDuplensky
EgorDuplensky reviewed Aug 20, 2024
View reviewed changes
src/plugins/intel_cpu/src/node.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/node.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/node.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/node.cpp Outdated Show resolved Hide resolved
@EgorDuplensky
Copy link
Contributor

@dmitry-gorokhov Ready for further steps

@dmitry-gorokhov
Copy link
Contributor

@IvanNovoselov I would ask you yo take a look as well

@yuxu42 yuxu42 requested a review from IvanNovoselov September 9, 2024 05:17
IvanNovoselov
IvanNovoselov approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@IvanNovoselov IvanNovoselov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections

@yuxu42
Copy link
Contributor

yuxu42 commented Sep 10, 2024

Hi @EgorDuplensky could you please take a look to see whether it can be merged? Thanks!

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Sep 26, 2024
Merged via the queue into openvinotoolkit:master with commit 507f31d Sep 26, 2024
152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz left review comments

@IvanNovoselov IvanNovoselov IvanNovoselov approved these changes

@EgorDuplensky EgorDuplensky EgorDuplensky approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@yuxu42 yuxu42 Awaiting requested review from yuxu42

@maxnick maxnick Awaiting requested review from maxnick

Assignees

@dmitry-gorokhov dmitry-gorokhov

@maxnick maxnick

Labels
category: CPU OpenVINO CPU plugin no_stale Do not mark as stale
Projects
None yet
Milestone
2024.4
Development

Successfully merging this pull request may close these issues.
8 participants
@xipingyan @dmitry-gorokhov @EgorDuplensky @yuxu42 @IvanNovoselov @praasz @maxnick @mg-intel