Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV64] Added SHL submodule support and T-Head toolchain #23901

Merged

Conversation

a-sidorova
Copy link
Contributor

@a-sidorova a-sidorova commented Apr 6, 2024

Details:

  • Support THead C910v (rv64gcv0p7_zfh_xtheadc)
  • Added the separate cmake toolchain for T-Head CPUs with rvv071

Tickets:

  • N/A

@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: build OpenVINO cmake script / infra category: dependency_changes Pull requests that update a dependency file labels Apr 6, 2024
@a-sidorova a-sidorova force-pushed the feature/riscv64/shl branch from 6c7da70 to 99873de Compare April 13, 2024 06:59
@a-sidorova a-sidorova marked this pull request as ready for review April 13, 2024 07:01
@a-sidorova a-sidorova requested review from a team as code owners April 13, 2024 07:01
@a-sidorova a-sidorova added the platform: risc-v OpenVINO on RISC-V label Apr 13, 2024
@dmitry-gorokhov
Copy link
Contributor

@EgorDuplensky could you please take a look?

@a-sidorova a-sidorova force-pushed the feature/riscv64/shl branch from 9a0f9ee to 2dc9b52 Compare May 1, 2024 16:55
@a-sidorova
Copy link
Contributor Author

@ilya-lavrenov @EgorDuplensky guys, could you take a look please? Thanks!

src/plugins/intel_cpu/CMakeLists.txt Outdated Show resolved Hide resolved
src/plugins/intel_cpu/CMakeLists.txt Outdated Show resolved Hide resolved
.gitmodules Outdated
@@ -84,3 +84,7 @@
[submodule "src/plugins/intel_cpu/thirdparty/libxsmm"]
path = src/plugins/intel_cpu/thirdparty/libxsmm
url = https://github.com/libxsmm/libxsmm.git
[submodule "src/plugins/intel_cpu/thirdparty/shl"]
path = src/plugins/intel_cpu/thirdparty/shl
url = https://github.com/a-sidorova/csi-nn2.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note based on offline discussion: it is not the best choice to use own dev fork as a thirdparty.
Ideally we should try to upstream required changes. If this is not feasible lets create official fork inside openvinotoolkit group.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we at least organize it the same way we do it for oneDNN?
Instead of "dev" branch, use 2.9.0_for_ie_master (I guess we better to refresh the naming we use)
And also have a clear explanation for the fork commits regarding why they are necessary
@dmitry-gorokhov @a-sidorova

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.
We will create the new master branch 2.90_for_ie_master in the new repository in openvinotoolkit group. At the moment, we're waiting for the repo creation: ticket 141759

Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jun 20, 2024
@mg-intel mg-intel removed the Stale label Jun 20, 2024
@a-sidorova
Copy link
Contributor Author

Finally, SHL fork was created in openvinotoolkit group where I created the new default branch v2.9.0._for_ie_master: https://github.com/openvinotoolkit/shl/tree/v2.9.0_for_ie_master

The PR in the SHL fork: openvinotoolkit/shl#2

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Jul 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2024
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Jul 10, 2024
Merged via the queue into openvinotoolkit:master with commit fd02ebd Jul 10, 2024
119 checks passed
@dmitry-gorokhov dmitry-gorokhov deleted the feature/riscv64/shl branch July 10, 2024 06:53
github-merge-queue bot pushed a commit that referenced this pull request Jul 17, 2024
### Details:
 - *Reused FC RVV from SHL*
- *The PR to SHL dev branch with accuracy fix for FC f32:
openvinotoolkit/shl#3

### Tickets:
 - *N/A*

### TODO:
- [x] Fix `execType: gemm_f32`
- [x] Added wrapper for `csinn_tensor` and `csinn_session` to allocate
these structures and deallocate them


### Prerequisites:
- [x] #23901
spran180 pushed a commit to spran180/openvino that referenced this pull request Jul 27, 2024
…oolkit#23901)

### Details:
 - *Support THead C910v (`rv64gcv0p7_zfh_xtheadc`)*
 - *Added the separate cmake toolchain for T-Head CPUs with rvv071*

### Tickets:
 - *N/A*
spran180 pushed a commit to spran180/openvino that referenced this pull request Jul 27, 2024
### Details:
 - *Reused FC RVV from SHL*
- *The PR to SHL dev branch with accuracy fix for FC f32:
openvinotoolkit/shl#3

### Tickets:
 - *N/A*

### TODO:
- [x] Fix `execType: gemm_f32`
- [x] Added wrapper for `csinn_tensor` and `csinn_session` to allocate
these structures and deallocate them


### Prerequisites:
- [x] openvinotoolkit#23901
github-merge-queue bot pushed a commit that referenced this pull request Aug 23, 2024
### Details:
 - *Added parallelism support for FC*
 - *Enabled OpenMP on rv64 by default*
 - *PR to oneDNN: openvinotoolkit/oneDNN#260

### Tickets:
 - *N/A *

### Prerequisites:
- [x] #23901
- [x] #23964
- [x] #26175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: build OpenVINO cmake script / infra category: CPU OpenVINO CPU plugin category: dependency_changes Pull requests that update a dependency file platform: risc-v OpenVINO on RISC-V
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants