-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RISCV64] Added SHL submodule support and T-Head toolchain #23901
[RISCV64] Added SHL submodule support and T-Head toolchain #23901
Conversation
6c7da70
to
99873de
Compare
@EgorDuplensky could you please take a look? |
7065a44
to
02e8644
Compare
02e8644
to
9a0f9ee
Compare
9a0f9ee
to
2dc9b52
Compare
@ilya-lavrenov @EgorDuplensky guys, could you take a look please? Thanks! |
.gitmodules
Outdated
@@ -84,3 +84,7 @@ | |||
[submodule "src/plugins/intel_cpu/thirdparty/libxsmm"] | |||
path = src/plugins/intel_cpu/thirdparty/libxsmm | |||
url = https://github.com/libxsmm/libxsmm.git | |||
[submodule "src/plugins/intel_cpu/thirdparty/shl"] | |||
path = src/plugins/intel_cpu/thirdparty/shl | |||
url = https://github.com/a-sidorova/csi-nn2.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note based on offline discussion: it is not the best choice to use own dev fork as a thirdparty.
Ideally we should try to upstream required changes. If this is not feasible lets create official fork inside openvinotoolkit group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we at least organize it the same way we do it for oneDNN?
Instead of "dev" branch, use 2.9.0_for_ie_master (I guess we better to refresh the naming we use)
And also have a clear explanation for the fork commits regarding why they are necessary
@dmitry-gorokhov @a-sidorova
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
We will create the new master branch 2.90_for_ie_master
in the new repository in openvinotoolkit group. At the moment, we're waiting for the repo creation: ticket 141759
42aef8b
to
0383f46
Compare
This PR will be closed in a week because of 2 weeks of no activity. |
0383f46
to
f0248a4
Compare
Finally, SHL fork was created in openvinotoolkit group where I created the new default branch The PR in the SHL fork: openvinotoolkit/shl#2 |
### Details: - *Reused FC RVV from SHL* - *The PR to SHL dev branch with accuracy fix for FC f32: openvinotoolkit/shl#3 ### Tickets: - *N/A* ### TODO: - [x] Fix `execType: gemm_f32` - [x] Added wrapper for `csinn_tensor` and `csinn_session` to allocate these structures and deallocate them ### Prerequisites: - [x] #23901
…oolkit#23901) ### Details: - *Support THead C910v (`rv64gcv0p7_zfh_xtheadc`)* - *Added the separate cmake toolchain for T-Head CPUs with rvv071* ### Tickets: - *N/A*
### Details: - *Reused FC RVV from SHL* - *The PR to SHL dev branch with accuracy fix for FC f32: openvinotoolkit/shl#3 ### Tickets: - *N/A* ### TODO: - [x] Fix `execType: gemm_f32` - [x] Added wrapper for `csinn_tensor` and `csinn_session` to allocate these structures and deallocate them ### Prerequisites: - [x] openvinotoolkit#23901
### Details: - *Added parallelism support for FC* - *Enabled OpenMP on rv64 by default* - *PR to oneDNN: openvinotoolkit/oneDNN#260 ### Tickets: - *N/A * ### Prerequisites: - [x] #23901 - [x] #23964 - [x] #26175
Details:
rv64gcv0p7_zfh_xtheadc
)Tickets: