Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Add MaxPool-14 and AvgPool-14 #23582

Merged
merged 105 commits into from
Jul 9, 2024
Merged

[CPU] Add MaxPool-14 and AvgPool-14 #23582

merged 105 commits into from
Jul 9, 2024

Conversation

p-wysocki
Copy link
Contributor

@p-wysocki p-wysocki commented Mar 20, 2024 •
edited
Loading

Details:

  • Added AvgPool-14 and MaxPool-14 to CPU plugin
  • Added shape inference tests
  • Added layer tests for MaxPool-14 and AvgPool-14
  • Refactored shape inference tests to avoid code duplication

Tickets:

Related PRs

@p-wysocki p-wysocki requested review from a team as code owners March 20, 2024 14:55
@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: CPU OpenVINO CPU plugin labels Mar 20, 2024
This was referenced Mar 20, 2024
Merged
Merged
@mlukasze mlukasze requested review from nshchego and removed request for riverlijunjie March 20, 2024 17:11
@dmitry-gorokhov
Copy link
Contributor

@nshchego please take a look as well

@p-wysocki
Copy link
Contributor Author

v14::AvgPool with CEIL_TORCH and static shapes is executed by CPU impl natively as v14 (no fallback to the ref)
v14::MaxPool with CEIL_TORCH, static shapes and single output is executed by CPU impl natively as v14 (no fallback the ref)

Test cases have been added asserting that there's no fallback to ref in these cases.

@p-wysocki p-wysocki requested a review from mitruska July 4, 2024 11:20
@p-wysocki p-wysocki requested a review from praasz July 4, 2024 14:14
@github-actions github-actions bot removed the category: CPP API OpenVINO CPP API bindings label Jul 5, 2024
@p-wysocki
Copy link
Contributor Author

Evaluate has been removed from AvgPool, all operations are now executed by CPU Plugin.

@p-wysocki p-wysocki requested a review from praasz July 8, 2024 07:52
dmitry-gorokhov
dmitry-gorokhov approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU part looks good to me

@mlukasze mlukasze added this pull request to the merge queue Jul 9, 2024
Merged via the queue into openvinotoolkit:master with commit 84530e7 Jul 9, 2024
122 checks passed
@p-wysocki p-wysocki deleted the pools_cpu branch July 9, 2024 07:53
spran180 pushed a commit to spran180/openvino that referenced this pull request Jul 27, 2024
@p-wysocki @mlukasze @spran180
[CPU] Add MaxPool-14 and AvgPool-14 (openvinotoolkit#23582)
df4e971 
### Details:
 - Added `AvgPool-14` and `MaxPool-14` to CPU plugin
 - Added shape inference tests
 - Added layer tests for `MaxPool-14` and `AvgPool-14`
 - Refactored shape inference tests to avoid code duplication

### Tickets:
 - CVS-136259

### Related PRs
 - openvinotoolkit#22930
 - openvinotoolkit#22796
 - openvinotoolkit#23381
 - openvinotoolkit#22966

---------

Co-authored-by: Michal Lukaszewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlukasze mlukasze mlukasze left review comments

@praasz praasz praasz approved these changes

@mitruska mitruska mitruska approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@alvoron alvoron Awaiting requested review from alvoron

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

@nshchego nshchego Awaiting requested review from nshchego

Assignees

@nshchego nshchego

Labels
category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common category: transformations OpenVINO Runtime library - Transformations Code Freeze no_stale Do not mark as stale
Projects
None yet
Milestone
2024.1
Development

Successfully merging this pull request may close these issues.
6 participants
@p-wysocki @dmitry-gorokhov @mitruska @mlukasze @nshchego @praasz