[CPU] [ARM64] jit emitter pipeline fix #23387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: IE Tests
eshoguli
force-pushed
the
es/cpu/arm_jit_emitters_pipeline_fix
branch
2 times, most recently
from
e2b2158 to
c690e53
Compare
github-actions
bot
removed
the
category: IE Tests
eshoguli
force-pushed
the
es/cpu/arm_jit_emitters_pipeline_fix
branch
5 times, most recently
from
5115e00 to
f5eba84
Compare
praasz
reviewed
Mar 13, 2024
| push_arg_entry_of("exp_pol5", 0x3c07cfce, true); | ||
| } | ||
|
|
||
| std::set<std::vector<element::Type>> jit_exp_emitter::get_supported_precisions(const std::shared_ptr<ov::Node>& node) { |
There was a problem hiding this comment.
Just detail
Suggested change
| std::set<std::vector<element::Type>> jit_exp_emitter::get_supported_precisions(const std::shared_ptr<ov::Node>& node) { | |
| std::set<element::TypeVector> jit_exp_emitter::get_supported_precisions(const std::shared_ptr<ov::Node>& node) { |
eshoguli
force-pushed
the
es/cpu/arm_jit_emitters_pipeline_fix
branch
from
f5eba84 to
6b42b2d
Compare
eshoguli
force-pushed
the
es/cpu/arm_jit_emitters_pipeline_fix
branch
from
6b42b2d to
be2b24a
Compare
eshoguli
force-pushed
the
es/cpu/arm_jit_emitters_pipeline_fix
branch
2 times, most recently
from
f5eba84 to
af36ad5
Compare
Merged
eshoguli
force-pushed
the
es/cpu/arm_jit_emitters_pipeline_fix
branch
2 times, most recently
from
6f31719 to
7fae5f9
Compare
|
@xuchen-intel Please review the changes |
xuchen-intel
requested changes
Mar 23, 2024
src/plugins/intel_cpu/src/emitters/plugin/aarch64/jit_emitter.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/emitters/plugin/aarch64/jit_emitter.cpp
Outdated
Show resolved
Hide resolved
eshoguli
force-pushed
the
es/cpu/arm_jit_emitters_pipeline_fix
branch
from
11b12b6 to
2182be7
Compare
eshoguli
force-pushed
the
es/cpu/arm_jit_emitters_pipeline_fix
branch
2 times, most recently
from
0c990ea to
008ad9a
Compare
eshoguli
force-pushed
the
es/cpu/arm_jit_emitters_pipeline_fix
branch
from
008ad9a to
94ec445
Compare
xuchen-intel
approved these changes
Mar 26, 2024
dmitry-gorokhov
approved these changes
Mar 28, 2024
| size_t _idx = end_gpr_idx - gpr_idx; // we allocate from the end | ||
|
|
||
| if (aux_gpr_idxs.size() >= get_aux_gprs_count()) break; | ||
| if ((_idx == Xbyak_aarch64::Operand::X18) || |
There was a problem hiding this comment.
Could you please clarify why these registers cannot bu used? Worth to add comment with the description. CAn be done in separate PR
bbielawx
pushed a commit
to bbielawx/openvino
that referenced
this pull request
Apr 12, 2024
### Details: - *[CPU] [ARM64] jit emitter pipeline fix*
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Apr 29, 2024
### Details: - *[CPU] [ARM64] jit emitter pipeline fix*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: