[GPU] Move event completion wait to first of execute_impl #23363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please check the performance of loop models? thanks. |
ahnyoung-paul
approved these changes
Mar 12, 2024
There is no performance regression in the target model. Thanks! |
yeonbok
reviewed
Mar 12, 2024
| // Wait for event completion | ||
| for (auto& e : events) { | ||
| e->wait(); | ||
| } |
There was a problem hiding this comment.
I believe this will cause regression..
I guess that the target issue is the event of "execution condition" right?
then I think we need to wait for only that event specifically, not for all events..
There was a problem hiding this comment.
I updated the event wait for only execution_condition. Thanks!
There was a problem hiding this comment.
@yeonbok No performance regression in several loop including models. Thanks!
I updated it! Thanks! |
praasz
pushed a commit
to praasz/openvino
that referenced
this pull request
Mar 13, 2024
…olkit#23363) ### Details: - Move event completion wait to first of execute_impl ### Tickets: - 129373
vishniakov-nikolai
pushed a commit
to vishniakov-nikolai/openvino
that referenced
this pull request
Mar 13, 2024
…olkit#23363) ### Details: - Move event completion wait to first of execute_impl ### Tickets: - 129373
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Apr 29, 2024
…olkit#23363) ### Details: - Move event completion wait to first of execute_impl ### Tickets: - 129373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: