[GPU] Skip broadcast when input and output shapes are identical #23331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-ddykim
force-pushed
the
gpu-skip-broadcast
branch
2 times, most recently
from
3383951 to
7202a71
Compare
yeonbok
reviewed
Mar 12, 2024
| // In this case, broadcast can not be optimized due to different input and output shapes. | ||
| if (node.have_user_with_type<reorder>() && node.get_users().size() == 1) | ||
| return; | ||
| node.can_be_optimized(true); |
There was a problem hiding this comment.
Is there any more possibility to reduce the target scope? I am afraid this will let most of the broadcasts be marked as can_be_opt so that less chance of the memory reuse, though the ratio of the actual optimizable cases is considered as small.. For example could we exclude more of "apparently not optimizable cases" like [-1, 1, -1, -1] [-1, 16, -1, -1]
There was a problem hiding this comment.
Oh... I'll try to reduce the target scope as you reviewed. Thank you.
There was a problem hiding this comment.
I added an additional condition not to skip broadcast. Thank you.
e-ddykim
force-pushed
the
gpu-skip-broadcast
branch
from
7202a71 to
c963ea2
Compare
andrew-k-park
approved these changes
Mar 12, 2024
hyunback
approved these changes
Mar 13, 2024
praasz
pushed a commit
to praasz/openvino
that referenced
this pull request
Mar 13, 2024
…vinotoolkit#23331) ### Details: - This PR makes some `Broadcast` layers to be skipped if input and output shapes are same. ### Tickets: - 135100
vishniakov-nikolai
pushed a commit
to vishniakov-nikolai/openvino
that referenced
this pull request
Mar 13, 2024
…vinotoolkit#23331) ### Details: - This PR makes some `Broadcast` layers to be skipped if input and output shapes are same. ### Tickets: - 135100
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Apr 29, 2024
…vinotoolkit#23331) ### Details: - This PR makes some `Broadcast` layers to be skipped if input and output shapes are same. ### Tickets: - 135100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Broadcastlayers to be skipped if input and output shapes are same.Tickets: