[GPU] Implement bias on internal FC op #23317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build_jenkins |
vladimir-paramuzov
approved these changes
Mar 8, 2024
| @@ -40,6 +40,7 @@ ConvertFullyConnectedToFullyConnectedCompressed::ConvertFullyConnectedToFullyCon | |||
| return in_ps.rank().is_static() && out_ps.rank().is_static() && in_ps.size() == 3 && out_ps.size() == 2; | |||
| }; | |||
|
|
|||
|
|
|||
| const ov::Output<Node> &decompression_scale, | ||
| const ov::Output<Node> &decompression_zero_point, | ||
| const ov::element::Type output_type = ov::element::undefined); | ||
|
|
||
| FullyConnectedCompressed(const ov::Output<Node> &A, | ||
| const ov::Output<Node> &B, | ||
| const ov::Output<Node> &bias, | ||
| const ov::Output<Node> &decompression_scale, | ||
| const ov::element::Type output_type = ov::element::undefined); |
There was a problem hiding this comment.
Since Placeholder op was added recently, we may now have single c-tor for this op with all arguments. Could you modify that too? Can be done in a separate PR if you want
| @@ -44,7 +44,8 @@ MoveFCReshapeToWeights::MoveFCReshapeToWeights() { | |||
| auto weights_input_m = std::make_shared<ov::pass::pattern::op::Or>(ov::OutputVector{reshape_m, transpose_m}); | |||
|
|
|||
| auto data_m = any_input(); | |||
| auto fully_connected_m = wrap_type<op::FullyConnected>({data_m, weights_input_m}); | |||
| auto bias_m = any_input(); | |||
| auto fully_connected_m = wrap_type<op::FullyConnected>({data_m, weights_input_m, bias_m}); | |||
There was a problem hiding this comment.
nit: I think there's no big sense to have named variable for bias in such cases. Something like this should be shorter and won't lose any meaningful info
auto fully_connected_m = wrap_type<op::FullyConnected>({data_m, weights_input_m, any_input()});
Added bias semantics support for internal FC op
p-durandin
approved these changes
Mar 12, 2024
Merged
via the queue into
openvinotoolkit:master
with commit Mar 12, 2024
ebde6c8
91 of 92 checks passed
praasz
pushed a commit
to praasz/openvino
that referenced
this pull request
Mar 13, 2024
Added bias semantics support for internal FC op ### Details: - Added bias semantics support for internal FC op
vishniakov-nikolai
pushed a commit
to vishniakov-nikolai/openvino
that referenced
this pull request
Mar 13, 2024
Added bias semantics support for internal FC op ### Details: - Added bias semantics support for internal FC op
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Apr 29, 2024
Added bias semantics support for internal FC op ### Details: - Added bias semantics support for internal FC op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added bias semantics support for internal FC op
Details: