[CPU][ARM] Enable NHWC in Reduce #23108
Conversation
|
There is a theory that SLT tests are passed because of tensor comparison issue. |
|
#PR23110 is in Merge Queue |
|
This PR will be closed in a week because of 2 weeks of no activity. |
github-actions
bot
added
the
category: IE Tests
This reverts commit c547654.
github-actions
bot
removed
the
category: IE Tests
|
@EgorDuplensky , could you please review? |
alvoron
force-pushed
the
alvoron_reduce_nhwc
branch
from
d93f189 to
3b6818f
Compare
alvoron
force-pushed
the
alvoron_reduce_nhwc
branch
from
3b6818f to
d5614d7
Compare
src/plugins/intel_cpu/src/transformations/cpu_opset/arm/pass/convert_reduce_no_keep_dims.cpp
Outdated
Show resolved
Hide resolved
| > | ||
| ReduceConvertCPUTestParamsSet; | ||
|
|
||
| class ReduceNoKeepDimsTransformationCPUTest: public testing::WithParamInterface<ReduceConvertCPUTestParamsSet>, |
There was a problem hiding this comment.
I think the idea was to write a unit test instead.
Since there is a corresponding single layer test which covers the inference functionality already.
There was a problem hiding this comment.
Replaced subgraph test with unit test
src/plugins/intel_cpu/src/transformations/cpu_opset/arm/pass/convert_reduce_no_keep_dims.cpp
Outdated
Show resolved
Hide resolved
| * Description: | ||
| * ConvertReduceNoKeepDimsBase detects Reduce operations with keepDims = false. | ||
| * Such Reduce operation is replaced with Reduce operation with keepDims = true and Squeeze | ||
| * which removes undesired dimensions. |
There was a problem hiding this comment.
@itikhono Could you please share your opinion regarding the appropriate place for this transformation? We do have an inverted one (where we fuse squeeze into reduce instead) in the common transformations scope. Isn't it better to place this one into the location of the common transformations as well?
I am not proposing to do this in scope of the current PR, but we could do it right after.
|
@maxnick Could you please take a look |
NHWC was disabled because of accuracy issue: ARM-software/ComputeLibrary#1044 CVS-114403 --------- Co-authored-by: eshoguli <[email protected]>
NHWC was disabled because of accuracy issue: ARM-software/ComputeLibrary#1044
CVS-114403