Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue caused by the changed tensor names after complex transformation #23081

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Fix the issue caused by the changed tensor names after complex transformation #23081

merged 8 commits into from
Mar 7, 2024

Conversation

yangwang201911
Copy link
Contributor

@yangwang201911 yangwang201911 commented Feb 26, 2024 •
edited
Loading

Details:

  • Update logic of port name checking to check if queried port tensor names is subset instead of op "==".
  • ...

Tickets:

@yangwang201911 yangwang201911 requested a review from a team as a code owner February 26, 2024 08:52
@github-actions github-actions bot added the category: inference OpenVINO Runtime library - Inference label Feb 26, 2024
@ilya-lavrenov
Copy link
Contributor

If you could eliminate usage of tensor names here https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/src/infer_request.cpp#L30, I think it will help.

It's related to CVS-132085

@ilya-lavrenov ilya-lavrenov added this to the 2024.1 milestone Feb 26, 2024
@yangwang201911
Copy link
Contributor Author

If you could eliminate usage of tensor names here https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/src/infer_request.cpp#L30, I think it will help.

It's related to CVS-132085

Will try this soon.

@yangwang201911 yangwang201911 requested review from a team as code owners February 28, 2024 01:52
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Feb 28, 2024
@github-actions github-actions bot removed the category: CPU OpenVINO CPU plugin label Feb 28, 2024
@yangwang201911
Copy link
Contributor Author

yangwang201911 commented Feb 28, 2024 •
edited
Loading

If you could eliminate usage of tensor names here https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/src/infer_request.cpp#L30, I think it will help.
It's related to CVS-132085

Will try this soon.

has synced with @zhaixuejun1993 and @riverlijunjie and PR23035 will remove the usage of tensor names within CVS-132085

@yangwang201911 yangwang201911 changed the title [WIP][CORE] Fix the issue caused by the changed tensor names after complex transformation Remove the usage of tensor names to address the port Feb 28, 2024
@yangwang201911 yangwang201911 changed the title Remove the usage of tensor names to address the port Fix the issue caused by the changed tensor names after complex transformation Feb 29, 2024
@peterchen-intel peterchen-intel added the pr: needs tests PR needs tests updating label Mar 4, 2024
songbell
songbell approved these changes Mar 7, 2024
View reviewed changes
src/inference/tests/unit/iplugin_test.cpp Outdated Show resolved Hide resolved
src/inference/tests/unit/iplugin_test.cpp Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov removed the pr: needs tests PR needs tests updating label Mar 7, 2024
@ilya-lavrenov ilya-lavrenov added the port to 2023.3 Need port from master to 2023.3 LTS label Mar 7, 2024
@ilya-lavrenov ilya-lavrenov enabled auto-merge March 7, 2024 10:24
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Mar 7, 2024
Merged via the queue into openvinotoolkit:master with commit 4f8f573 Mar 7, 2024
108 checks passed
@yangwang201911 yangwang201911 mentioned this pull request Mar 8, 2024
Merged
ilya-lavrenov pushed a commit that referenced this pull request Mar 8, 2024
@yangwang201911
Update port name checking logic to 2023.3 (#23339)
735a3ba 
Port from #23081 to
2023.3
### Details:
 - *item1*
 - *...*

### Tickets:
 - 122932
@ilya-lavrenov ilya-lavrenov removed the port to 2023.3 Need port from master to 2023.3 LTS label Mar 8, 2024
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@yangwang201911 @alvoron
Fix the issue caused by the changed tensor names after complex transf…
f5e0c43 
…ormation (openvinotoolkit#23081)

### Details:
- Update logic of port name checking to check if queried port tensor
names is subset instead of op "==".
 - *...*

### Tickets:
 - CVS-122932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songbell songbell songbell approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@peterchen-intel peterchen-intel Awaiting requested review from peterchen-intel

@WeldonWangwang WeldonWangwang Awaiting requested review from WeldonWangwang

Assignees

@ilya-lavrenov ilya-lavrenov

@songbell songbell

Labels
category: inference OpenVINO Runtime library - Inference
Projects
None yet
Milestone
2024.1
Development

Successfully merging this pull request may close these issues.
4 participants
@yangwang201911 @ilya-lavrenov @songbell @peterchen-intel