[CPU] Introduce gemm conv post op checks #23059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-gorokhov
approved these changes
Feb 26, 2024
|
@luweizhou2016, FYI |
maxnick
force-pushed
the
fix_gemm_conv_post_op_checks
branch
from
9b2ba8b to
3ab87a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Gemm convolution supports binary post ops only in the
jit_pp_kernel, whileref_pp_kerneldoesn't support such functionality. More over, even supporting binary post ops, thejit_pp_kerneldoesn't perform all the necessary checks to ensure proper functioning and memory consistency. This PR introduces all the necessary checks to avoid any runtime errors caused by improper post ops configurations being applied unconditionally.Tickets: