Delete check that ReadValue/Assign operations have to be in pair in ov::Model #23051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkazants
reviewed
Feb 24, 2024
| @@ -220,11 +220,6 @@ void ov::Model::prerequirements(bool detect_variables, bool detect_parameters) { | |||
| void ov::Model::validate_nodes_and_infer_types() const { | |||
There was a problem hiding this comment.
is it possible to add a test with a graph when this check is not needed?
There was a problem hiding this comment.
I agree, we need to double check if we have these tests or not but not in this PR
slyalin
approved these changes
Mar 5, 2024
Pranshu-S
pushed a commit
to Pranshu-S/openvino
that referenced
this pull request
Mar 7, 2024
…v::Model (openvinotoolkit#23051) ### Details: If ReadValue and Assign are not paired in model topology we have "Model is incorrect. Assign and ReadValue operations must be in pairs on the network." Check for ReadValue-Assign pairs is useless and it is an obstacle for model transformation debugging. Moreover, with more advanced techniques of state modification there can be other ops (custom ones) that modify state in place. ### Tickets: - *CVS-133159*
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Apr 29, 2024
…v::Model (openvinotoolkit#23051) ### Details: If ReadValue and Assign are not paired in model topology we have "Model is incorrect. Assign and ReadValue operations must be in pairs on the network." Check for ReadValue-Assign pairs is useless and it is an obstacle for model transformation debugging. Moreover, with more advanced techniques of state modification there can be other ops (custom ones) that modify state in place. ### Tickets: - *CVS-133159*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
If ReadValue and Assign are not paired in model topology we have "Model is incorrect. Assign and ReadValue operations must be in pairs on the network."
Check for ReadValue-Assign pairs is useless and it is an obstacle for model transformation debugging. Moreover, with more advanced techniques of state modification there can be other ops (custom ones) that modify state in place.
Tickets: