[CPU] Updated aux GPR count for Load/Store emitters #23046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chenhu-wang could you take a look please as author of these implementations? Thanks in advance! |
a-sidorova
force-pushed
the
feature/cpu/load_store_emitters_aux_gprs
branch
from
82979eb to
1c03bc6
Compare
chenhu-wang
reviewed
Feb 26, 2024
src/plugins/intel_cpu/src/emitters/plugin/x64/jit_load_store_emitters.cpp
Outdated
Show resolved
Hide resolved
chenhu-wang
reviewed
Feb 26, 2024
src/plugins/intel_cpu/src/emitters/plugin/x64/jit_load_store_emitters.cpp
Outdated
Show resolved
Hide resolved
a-sidorova
force-pushed
the
feature/cpu/load_store_emitters_aux_gprs
branch
from
3dd8862 to
487083e
Compare
chenhu-wang
approved these changes
Feb 27, 2024
|
@chenhu-wang thanks a lot for the review and help! @dmitry-gorokhov could you please take a look as well? Thanks in advance! |
a-sidorova
force-pushed
the
feature/cpu/load_store_emitters_aux_gprs
branch
from
487083e to
186c1e2
Compare
dmitry-gorokhov
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
get_aux_gprfor Load and Store emitters to avoid extrapushandpopfor some cases. Example of one FP32 element loading onAVX512machine:Tickets: