Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Moved Ngram fusion with SymbolicOpts before Snippets pipeline #22967

Merged
merged 2 commits into from
Feb 27, 2024
Merged

[CPU] Moved Ngram fusion with SymbolicOpts before Snippets pipeline #22967

merged 2 commits into from
Feb 27, 2024

Conversation

a-sidorova
Copy link
Contributor

Details:

  • Moved Ngram fusion with SymbolicOpts before Snippets pipeline because Ngram contains eltwise ops that can be tokenized by Snippets in the near future when dynamism will be supported

Tickets:

  • N/A

@a-sidorova a-sidorova requested review from a team as code owners February 20, 2024 13:30
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Feb 20, 2024
@a-sidorova a-sidorova changed the title [CPU][WIP] Moved Ngram fusion with SymbolicOpts before Snippets pipeline [CPU] Moved Ngram fusion with SymbolicOpts before Snippets pipeline Feb 26, 2024
@dmitry-gorokhov dmitry-gorokhov self-assigned this Feb 26, 2024
@dmitry-gorokhov dmitry-gorokhov added this to the 2024.1 milestone Feb 26, 2024
dmitry-gorokhov
dmitry-gorokhov approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets try to check if related model works as expected after the changes

@a-sidorova a-sidorova force-pushed the feature/cpu/move_ngram_before_snippets branch from a73d778 to 4c57bc7 Compare February 27, 2024 05:39
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Feb 27, 2024
Merged via the queue into openvinotoolkit:master with commit b4d26b6 Feb 27, 2024
101 checks passed
@dmitry-gorokhov dmitry-gorokhov deleted the feature/cpu/move_ngram_before_snippets branch February 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-Golubev v-Golubev v-Golubev approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2024.1
Development

Successfully merging this pull request may close these issues.
3 participants
@a-sidorova @dmitry-gorokhov @v-Golubev