Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OpExtension in frontends #22961

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Support OpExtension in frontends #22961

merged 5 commits into from
Feb 23, 2024

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Feb 20, 2024

Details:

  • Support OpExtension in frontends
  • Support OPENVINO_FRAMEWORK_MAP for PyTorch FE

Tickets:

@mvafin mvafin requested review from a team as code owners February 20, 2024 11:12
@mvafin mvafin requested review from kblaszczak-intel and PiotrKrzem and removed request for a team February 20, 2024 11:12
@github-actions github-actions bot added category: MO Model Optimizer category: Core OpenVINO Core (aka ngraph) category: docs OpenVINO documentation category: ONNX FE OpenVINO ONNX FrontEnd category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: TF FE OpenVINO TensorFlow FrontEnd category: CPP API OpenVINO CPP API bindings category: PyTorch FE OpenVINO PyTorch Frontend labels Feb 20, 2024
ilya-lavrenov
ilya-lavrenov approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we cover by tests the original issue with C++ macro OPENVINO_FRAMEWORK_MAP(pytorch) ?

@ilya-lavrenov ilya-lavrenov added this to the 2024.1 milestone Feb 20, 2024
@mvafin
Copy link
Contributor Author

mvafin commented Feb 20, 2024

@ilya-lavrenov Agree, will add test

rkazants
rkazants requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that it works for TF FE

@mvafin mvafin requested review from a team as code owners February 21, 2024 15:25
@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: docs_snippets OpenVINO docs snippets (docs/snippets) labels Feb 21, 2024
@mvafin mvafin requested a review from rkazants February 21, 2024 15:25
@ilya-lavrenov ilya-lavrenov merged commit 5f64019 into openvinotoolkit:master Feb 23, 2024
105 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz approved these changes

@PiotrKrzem PiotrKrzem PiotrKrzem approved these changes

@rkazants rkazants rkazants approved these changes

@eaidova eaidova eaidova approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@gkrivor gkrivor Awaiting requested review from gkrivor

@kblaszczak-intel kblaszczak-intel Awaiting requested review from kblaszczak-intel kblaszczak-intel is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: docs_snippets OpenVINO docs snippets (docs/snippets) category: docs OpenVINO documentation category: IE Tests OpenVINO Test: plugins and common category: MO Model Optimizer category: ONNX FE OpenVINO ONNX FrontEnd category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: PyTorch FE OpenVINO PyTorch Frontend category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd
Projects
None yet
Milestone
2024.1
Development

Successfully merging this pull request may close these issues.
7 participants
@mvafin @ilya-lavrenov @eaidova @rkazants @PiotrKrzem @praasz @slyalin