C samples build fix #2293
Closed
C samples build fix #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-lavrenov
added
category: build
Merged
openvino-pushbot
added
the
category: inference
mryzhov
reviewed
Sep 16, 2020
| @@ -145,6 +145,9 @@ endif() | |||
| # exactly the same OpenCV_DIR path which was used for the InferenceEngine build | |||
| if(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/common/format_reader") | |||
| add_subdirectory(common/format_reader) | |||
| elseif(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/common") | |||
| # opencv_wrapper_c for C samples is here | |||
| add_subdirectory(common) | |||
There was a problem hiding this comment.
it is better to isolate opencv_wraper like done for cpp samples, for example, common/opencv_c_wraper
There was a problem hiding this comment.
I've included your gflags commit + changed the subproject name in #2278 to fix this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.