Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed /Zi from gtest #22866

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented Feb 15, 2024

Details:

  • There is no need to keep /Zi at all, because OV will propagate all its flags to gtest

@ilya-lavrenov ilya-lavrenov requested a review from a team as a code owner February 15, 2024 15:08
@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: build OpenVINO cmake script / infra labels Feb 15, 2024
@ilya-lavrenov ilya-lavrenov added this to the 2024.1 milestone Feb 15, 2024
@ilya-lavrenov ilya-lavrenov added the port to 2023.3 Need port from master to 2023.3 LTS label Feb 15, 2024
@ababushk ababushk enabled auto-merge February 15, 2024 15:32
@ilya-lavrenov ilya-lavrenov merged commit c8a5434 into openvinotoolkit:master Feb 15, 2024
83 of 99 checks passed
@ilya-lavrenov ilya-lavrenov deleted the gtest-pdb branch February 15, 2024 16:48
ilya-lavrenov added a commit to ilya-lavrenov/openvino that referenced this pull request Feb 17, 2024
### Details:
- There is no need to keep `/Zi` at all, because OV will propagate all
its flags to gtest
ilya-lavrenov added a commit to ilya-lavrenov/openvino that referenced this pull request Feb 17, 2024
### Details:
- There is no need to keep `/Zi` at all, because OV will propagate all
its flags to gtest
ilya-lavrenov added a commit that referenced this pull request Feb 17, 2024
### Details:
- There is no need to keep `/Zi` at all, because OV will propagate all
its flags to gtest

### Details:
 - Ported #22866
ilya-lavrenov added a commit that referenced this pull request Feb 19, 2024
### Ported from master:
- #22816
- #22847
- #22866

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Maksim Kutakov <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ilya-lavrenov ilya-lavrenov removed the port to 2023.3 Need port from master to 2023.3 LTS label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: build OpenVINO cmake script / infra category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants