-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TF FE] Fix centernet and correct FloorDiv translator for signed integer type #22684
Conversation
3365748
to
ad11f4c
Compare
6716556
to
4aae998
Compare
4aae998
to
58d493d
Compare
@popovaan @rkazants i reverted removing of abs and instead added a separate tests cases where i statically specify inputs instead of random generation. I found that even for a very simple cases the current main, e.g. because if this denominator 10 is converted to Div(input_1, 10) => Mul(input_1, 1/10) then when 1/10 = 0.1 is compressed to f16 it becomes 0.099975.., which causes difference even for CPU inference!!! (because floor(10 * 0.099..) = floor(0.99..) = 0)
One more thing, since layer test call |
afddbe7
to
3f6cedd
Compare
@alvoron FYI since Div for signed ints on Arm returns values different from cpu/gpu this FloorDiv also differ. xfailed Div and FloorDiv layer tests for arm until CVS-132377 is resolved. |
Co-authored-by: Roman Kazantsev <[email protected]>
Co-authored-by: Roman Kazantsev <[email protected]>
Details:
Centernet's topk operation returns large int32 values (greater than 1000000), even though they are integer
FloorDiv
/Div(inp_1, inp_2) + Floor
operation is performed in float16 and because of that it causes accuracy problems.To solve this need to performs FloorDiv operation in integer with a subgraph:
Tickets: