Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Fix gemm_ref and gemm_tiled_opt #22617

Merged
merged 4 commits into from
Feb 8, 2024
Merged

[GPU] Fix gemm_ref and gemm_tiled_opt #22617

merged 4 commits into from
Feb 8, 2024

Conversation

e-ddykim
Copy link
Contributor

@e-ddykim e-ddykim commented Feb 2, 2024 •
edited
Loading

Details:

  • Fixed gemm::calc_output_layout() to consider output_order
  • Fixed gemm_ref for output transposed cases
  • Fixed wrong matmul axis (K- axis) selection for 2/3 dim inputs
  • Updated gemm_tiled_opt to support padded inputs

Tickets:

  • 131014

@e-ddykim e-ddykim requested review from a team as code owners February 2, 2024 08:04
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Feb 2, 2024
@e-ddykim e-ddykim force-pushed the gpu-extend-gemm-fix branch from d801afe to 178ed6a Compare February 5, 2024 14:18
@e-ddykim e-ddykim changed the title [GPU] Fix gemm::calc_output_layout() [GPU] Fix gemm_ref and gemm_tiled_opt Feb 5, 2024
@e-ddykim e-ddykim force-pushed the gpu-extend-gemm-fix branch from 178ed6a to 7ee180a Compare February 6, 2024 05:19
@e-ddykim e-ddykim force-pushed the gpu-extend-gemm-fix branch from 7ee180a to 8b81058 Compare February 6, 2024 11:07
@yeonbok yeonbok added this pull request to the merge queue Feb 8, 2024
@yeonbok
Copy link
Contributor

yeonbok commented Feb 8, 2024

Please update unittest in a separate PR.

Merged via the queue into openvinotoolkit:master with commit 3b7b30c Feb 8, 2024
87 checks passed
@e-ddykim e-ddykim deleted the gpu-extend-gemm-fix branch February 8, 2024 05:04
@e-ddykim
Copy link
Contributor Author

Please update unittest in a separate PR.

I added unit tests in this PR (#22769).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-k-park andrew-k-park andrew-k-park approved these changes

@ahnyoung-paul ahnyoung-paul ahnyoung-paul approved these changes

@yeonbok yeonbok yeonbok approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e-ddykim @yeonbok @ahnyoung-paul @andrew-k-park