Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX ] Update Trilu to accept single value tensor #22286

Merged
merged 6 commits into from
Apr 3, 2024
Merged

[ONNX ] Update Trilu to accept single value tensor #22286

merged 6 commits into from
Apr 3, 2024

Conversation

siddhant-0707
Copy link
Contributor

@siddhant-0707 siddhant-0707 commented Jan 21, 2024 •
edited by ilya-lavrenov
Loading

Details:

  • update trilu.cpp

Tickets:

@siddhant-0707 siddhant-0707 requested a review from a team as a code owner January 21, 2024 12:01
@siddhant-0707 siddhant-0707 changed the title Update Trilu to accept single value tensor [ONNX ]Update Trilu to accept single value tensor Jan 21, 2024
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Jan 21, 2024
@siddhant-0707 siddhant-0707 changed the title [ONNX ]Update Trilu to accept single value tensor [ONNX ] Update Trilu to accept single value tensor Jan 21, 2024
@ilya-lavrenov ilya-lavrenov added the ExternalPR External contributor label Feb 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Feb 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Feb 27, 2024
@siddhant-0707
Copy link
Contributor Author

@mitruska @gkrivor please take a look, just a minor change. I've updated the PR (clang-format)

@siddhant-0707
Copy link
Contributor Author

all tests passing

@mitruska mitruska reopened this Apr 2, 2024
@gkrivor
Copy link
Contributor

gkrivor commented Apr 2, 2024

build_jenkins

@gkrivor
Copy link
Contributor

gkrivor commented Apr 2, 2024

build_jenkins

@gkrivor
Copy link
Contributor

gkrivor commented Apr 2, 2024

build_jenkins

@github-actions github-actions bot removed the Stale label Apr 3, 2024
@gkrivor gkrivor added this pull request to the merge queue Apr 3, 2024
Merged via the queue into openvinotoolkit:master with commit 1e941dc Apr 3, 2024
108 checks passed
@mlukasze mlukasze added this to the 2024.1 milestone Apr 3, 2024
bbielawx pushed a commit to bbielawx/openvino that referenced this pull request Apr 12, 2024
@siddhant-0707 @gkrivor @bbielawx
[ONNX ] Update Trilu to accept single value tensor (openvinotoolkit…
c5f7926 
…#22286)

### Details:
 - update `trilu.cpp`

### Tickets:
 - Closes openvinotoolkit#21172

---------

Co-authored-by: Georgy Krivoruchko <[email protected]>
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@siddhant-0707 @gkrivor @alvoron
[ONNX ] Update Trilu to accept single value tensor (openvinotoolkit…
1c35bed 
…#22286)

### Details:
 - update `trilu.cpp`

### Tickets:
 - Closes openvinotoolkit#21172

---------

Co-authored-by: Georgy Krivoruchko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkrivor gkrivor gkrivor approved these changes

@rkazants rkazants Awaiting requested review from rkazants

Assignees

@gkrivor gkrivor

Labels
category: ONNX FE OpenVINO ONNX FrontEnd ExternalPR External contributor
Projects
None yet
Milestone
2024.1
Development

Successfully merging this pull request may close these issues.

[Bug]: Trilu second input must be a scalar
6 participants
@siddhant-0707 @gkrivor @rkazants @ilya-lavrenov @mitruska @mlukasze