Test refactor #2225
Merged
Test refactor #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pszmel
requested review from
postrational,
blesniewski,
sdurawa,
ggalieroc-zz and
a team
postrational
approved these changes
Sep 16, 2020
| @@ -158,7 +136,7 @@ NGRAPH_TEST(${BACKEND_NAME}, dequantize_zero_offset) | |||
| auto offset = op::Constant::create(input_type, scale_offset_shape, {0}); | |||
| auto dequantize = make_shared<op::Dequantize>(X, scale, offset, output_type, quantization_axes); | |||
| auto f = make_shared<Function>(dequantize, ParameterVector{X}); | |||
|
|
|||
| #if 0 | |||
There was a problem hiding this comment.
Please remove this pre-processing instance, we only need the #else part of this code
…uantize, dequantize and quantize_zero_offset from 'backend/quantize_dequantize' refactored.
blesniewski
reviewed
Sep 16, 2020
There was a problem hiding this comment.
@pszmel - have you verified in some way that the results of the tests you refactored are the same before and after the refactor?
tomdol
approved these changes
Sep 16, 2020
I copied the expected results from pre-refactored test and add them to expected_output in refactored tests. I guess that tests would not pass if I failed with copying. |
blesniewski
approved these changes
Sep 16, 2020
pszmel
force-pushed
the
test_refactor
branch
from
5620a86 to
e696036
Compare
ggalieroc-zz
approved these changes
Sep 16, 2020
sdurawa
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.