Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change number of streams in latency mode on XEON to 1 #22216

Merged

Conversation

wangleis
Copy link
Contributor

Details:

  • Change number of streams in latency mode on XEON to 1
  • Update CPU unit test

Tickets:

@wangleis wangleis requested review from a team as code owners January 17, 2024 15:03
@wangleis wangleis requested review from xufang-lisa and removed request for a team January 17, 2024 15:03
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jan 17, 2024
@dmitry-gorokhov dmitry-gorokhov added this to the 2024.0 milestone Jan 18, 2024
@dmitry-gorokhov
Copy link
Contributor

dmitry-gorokhov commented Jan 22, 2024

@wangleis I tried this PR and see the following behavior:

  1. If I specify hint latency only infer happens on single socket.
  2. If I additionally to latency hint specify nstreams=1 it starts to use both sockets.
    I would say this is not expected behavior. We should use single socket by default for any case. If user wants to use both socket, then nthreads should be manually specified.
    Alternativelly we might consider exposure of LatencyThreadingMode as cpu property to make set up process more convenient for workloads where whole systems should be occupied.

@wangleis
Copy link
Contributor Author

@wangleis I tried this PR and see the following behavior:

  1. If I specify hint latency only infer happens on single socket.
  2. If I additionally to latency hint specify nstreams=1 it starts to use both sockets.
    I would say this is not expected behavior. We should use single socket by default for any case. If user wants to use both socket, then nthreads should be manually specified.
    Alternativelly we might consider exposure of LatencyThreadingMode as cpu property to make set up process more convenient for workloads where whole systems should be occupied.

@dmitry-gorokhov Updated. Please try again.

@dmitry-gorokhov dmitry-gorokhov merged commit 7052c23 into openvinotoolkit:master Jan 23, 2024
95 checks passed
@wangleis wangleis deleted the xeon_latency_one_stream branch March 5, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants