Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ngraph AlignedBuffer/SharedBuffer #22182

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Delete ngraph AlignedBuffer/SharedBuffer #22182

merged 4 commits into from
Jan 19, 2024

Conversation

vurusovs
Copy link
Contributor

@vurusovs vurusovs commented Jan 16, 2024 •
edited
Loading

Tickets:

@vurusovs vurusovs requested review from a team as code owners January 16, 2024 10:09
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: CPP API OpenVINO CPP API bindings labels Jan 16, 2024
ilya-lavrenov
ilya-lavrenov approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, fix clang format issues

@ilya-lavrenov ilya-lavrenov added this to the 2024.0 milestone Jan 16, 2024
@vurusovs vurusovs force-pushed the vu/cpu_tests_api10_remove branch from b3f8850 to df66219 Compare January 16, 2024 11:13
@ilya-lavrenov ilya-lavrenov enabled auto-merge (squash) January 16, 2024 11:19
@vurusovs vurusovs mentioned this pull request Jan 16, 2024
Closed
@vurusovs vurusovs force-pushed the vu/cpu_tests_api10_remove branch 2 times, most recently from df8baca to 195e61d Compare January 17, 2024 06:09
@vurusovs vurusovs disabled auto-merge January 18, 2024 07:10
@vurusovs vurusovs force-pushed the vu/cpu_tests_api10_remove branch from 195e61d to 43af61f Compare January 18, 2024 07:42
praasz
praasz reviewed Jan 18, 2024
View reviewed changes
src/core/include/openvino/op/constant.hpp
@@ -12,7 +12,8 @@
# define WAS_OV_LIBRARY_DEFINED_CONSTANT
#endif

#include "ngraph/runtime/shared_buffer.hpp"
#include "ngraph/util.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it in #22184, but the change requires a lot of fixes

@vurusovs vurusovs force-pushed the vu/cpu_tests_api10_remove branch from 29bf8c6 to eb1b4bc Compare January 18, 2024 12:50
@vurusovs vurusovs force-pushed the vu/cpu_tests_api10_remove branch from eb1b4bc to 3b7528c Compare January 19, 2024 11:24
@ilya-lavrenov ilya-lavrenov requested a review from praasz January 19, 2024 11:32
@ilya-lavrenov ilya-lavrenov enabled auto-merge (squash) January 19, 2024 14:45
@ilya-lavrenov ilya-lavrenov merged commit 635665a into openvinotoolkit:master Jan 19, 2024
96 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@praasz praasz Awaiting requested review from praasz

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2024.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vurusovs @ilya-lavrenov @praasz