Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAPI] remove legacy CAPI source code and document #21916

Merged

Conversation

riverlijunjie
Copy link
Contributor

@riverlijunjie riverlijunjie commented Jan 2, 2024

Details:

  • Remove legacy C API.
  • Update documents.

Tickets:

  • 128245

@riverlijunjie riverlijunjie requested review from a team as code owners January 2, 2024 07:58
@riverlijunjie riverlijunjie requested review from akopytko and removed request for a team January 2, 2024 07:58
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: C API OpenVINO C API bindings category: CI OpenVINO public CI category: docs OpenVINO documentation github_actions Pull requests that update GitHub Actions code category: docs_snippets OpenVINO docs snippets (docs/snippets) labels Jan 2, 2024
@riverlijunjie riverlijunjie force-pushed the river/remove_legacy_capi_src branch from a6e5fee to fb8818e Compare January 2, 2024 08:00
@@ -145,11 +145,3 @@ int main_new() {
return 0;
}

int main_old() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all migration files may be removed

@ilya-lavrenov please, comment. If yes, let's remove it in next PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, they should be removed

@@ -29,7 +29,7 @@ OpenVINO C API has the following structure:
* [src](./src) contains the implementations of all C APIs.
* [tests](./tests) contains all tests for OpenVINO C APIs. [Learn more](./docs/how_to_write_unit_test.md).

> **NOTE**: Using API 2.0 is strongly recommended. Legacy API (for C) [header file](./include/c_api/ie_c_api.h), [source file](./src/ie_c_api.cpp), [unit test](./tests/ie_c_api_test.cpp) are also included in the component, but the legacy API is no longer extended.
> **NOTE**: Using API 2.0 is strongly recommended. Legacy API (for C) has been removed from 2024.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **NOTE**: Using API 2.0 is strongly recommended. Legacy API (for C) has been removed from 2024.0.
> **NOTE**: Legacy Inference Engine API (for C) has been removed from 2024.0.


## OV Core

This strcut represents OpenVINO entity and allows you to manipulate with plugins using unified interfaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This strcut represents OpenVINO entity and allows you to manipulate with plugins using unified interfaces.
This struct represents OpenVINO entity and allows you to manipulate with plugins using unified interfaces.


- Description: Loads a network that was read from the Intermediate Representation (IR) to the plugin with specified device name and creates an `ie_executable_network_t` instance of the `ie_network_t` struct.
You can create as many networks as you need and use them simultaneously (up to the limitation of the hardware resources).
- Description: Reads models from IR / ONNX / PDPD / TF / TFLite formats to create ov_model_t.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Description: Reads models from IR / ONNX / PDPD / TF / TFLite formats to create ov_model_t.
- Description: Reads models from IR / PyTorch / ONNX / PDPD / TF / TFLite formats to create ov_model_t.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update these documentation issued in the next PR.

@vurusovs vurusovs merged commit d3398d2 into openvinotoolkit:master Jan 5, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: build OpenVINO cmake script / infra category: C API OpenVINO C API bindings category: CI OpenVINO public CI category: docs_snippets OpenVINO docs snippets (docs/snippets) category: docs OpenVINO documentation github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants