[GPU] Fix issue for skipping gather #21887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonbok
reviewed
Dec 28, 2023
yeonbok
reviewed
Dec 28, 2023
ahnyoung-paul
force-pushed
the
fix_gather_issue
branch
2 times, most recently
from
465a430 to
aee3c36
Compare
|
Also as I mentioned in the offline chat, I think we can move do_rintime... stuffs to be done after empty primitive skipping. Because if the node is empty we do not need to do anything for that op already. Currently, the issue seems to happen for empty input primitive + its user's do_runtime_... check where it is trying to do something with its input mem. However we just can skip that user node if it is empty, before do the mem check and update things for those user nodes. So the priority of the optimization should be like this: runtime empty primitive skipping => further optimization in runtime (where we check the parent's memory, etc) |
yeonbok
reviewed
Jan 2, 2024
ahnyoung-paul
force-pushed
the
fix_gather_issue
branch
3 times, most recently
from
c61dec9 to
34429b6
Compare
yeonbok
approved these changes
Jan 3, 2024
|
Note: To add corresponding test as a follow up work |
ahnyoung-paul
force-pushed
the
fix_gather_issue
branch
from
34429b6 to
c4b60a3
Compare
ahnyoung-paul
force-pushed
the
fix_gather_issue
branch
from
c4b60a3 to
c786de1
Compare
- checkout input layout is zero count before calling dep_memory() - add the case for input layout count is zero - in gather_inst, run build_deps before checking is_the_same_buffer(output_memory(), input_memory())
…ntime_skip_gather do_runtime_in_place_kv_cache
… current node is skpped for empty output tensor
…empty and indices is empty
…front of chekcing skip execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: