Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Extend ONNX Frontend with BitwiseOr-18 operator #21755

Merged
merged 14 commits into from
Dec 21, 2023

Conversation

rghvsh
Copy link
Contributor

@rghvsh rghvsh commented Dec 19, 2023

Details:

  • Implemented ONNX frontend BitwiseOr operator and corresponding tests.

Tickets:

@rghvsh rghvsh requested a review from a team as a code owner December 19, 2023 10:35
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Dec 19, 2023
@ilya-lavrenov ilya-lavrenov added this to the 2024.0 milestone Dec 19, 2023
@mlukasze mlukasze requested a review from mmikolajcz December 19, 2023 10:48
@rghvsh rghvsh requested a review from a team as a code owner December 19, 2023 11:15
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Dec 19, 2023
@mlukasze
Copy link
Contributor

build_jenkins

Copy link
Contributor

@mmikolajcz mmikolajcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, PR looks great!
I've left one comment regarding code style with some guides how to fix it.

src/frontends/onnx/frontend/src/op/bitwise_or.cpp Outdated Show resolved Hide resolved
@mmikolajcz
Copy link
Contributor

Hello @mlukasze @gkrivor ! Under the clang-format check log it shows :

Raw Output:
src/frontends/onnx/frontend/src/op/bitwise_or.cpp:5:-#include "op/bitwise_or.hpp"
src/frontends/onnx/frontend/src/op/bitwise_or.cpp:5:+#include "op/bitwise_or.hpp"
Error: Process completed with exit code 1.

I ran clang-format command on the code there was no change, what does this error refer to?

Thanks Raghav

I think issue is due to 2 whitespaces at the end of line +#include "op/bitwise_or.hpp" . Probably you would need to turn on whitespace rendering option in your IDE to catch it

Copy link
Contributor

@mmikolajcz mmikolajcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quick fix, lets wait for CI to pass :)

@mmikolajcz
Copy link
Contributor

build_jenkins

@gkrivor
Copy link
Contributor

gkrivor commented Dec 20, 2023

Hi, wheels failed due to issue with uint64 test case OnnxBackendNodeModelTest.test_bitwise_or_ui64_bcast_3v1d_cpu

Please, add it to skipped list as for bitwise_and.

@mmikolajcz
Copy link
Contributor

build_jenkins

@rghvsh
Copy link
Contributor Author

rghvsh commented Dec 20, 2023

Hi! @mmikolajcz @gkrivor Is there a community forum like a discord/slack channel or a mailing list for OpenVINO?

Thanks
Raghav

@mlukasze
Copy link
Contributor

hey @rghvsh

discord will be available after new year, we are preparing for xmas break and we might not be able to serve communication with you guys in a proper way.

@gkrivor gkrivor merged commit 1a0f0cc into openvinotoolkit:master Dec 21, 2023
103 checks passed
@ilya-lavrenov ilya-lavrenov added the ExternalPR External contributor label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd category: Python API OpenVINO Python bindings ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Extend ONNX Frontend with BitwiseOr-18 operator
5 participants