Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] StringMemory for the output tensor in the InferRequest #21746

Merged

Conversation

nshchego
Copy link
Contributor

Details:

  • **

Tickets:

  • 127800

@nshchego nshchego requested review from a team as code owners December 19, 2023 06:13
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Dec 19, 2023
@nshchego nshchego force-pushed the cpu/bug/string_out_tensor branch from 2a33f62 to 42481e1 Compare December 19, 2023 06:24
Copy link
Contributor

@slyalin slyalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tokenizer tests migrated to string tensors pass rate almost the same as was without string tensors, so this PR definitely fixes the regression.

@dmitry-gorokhov dmitry-gorokhov added this to the 2023.3 milestone Dec 19, 2023
tensor = control_block.tensor();
if (model_prec == graph_prec)
m_outputControlBlocks.emplace(std::make_pair(name, std::move(control_block)));
if (model_prec == element::string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need to incapsulate this logic into OutputControlBlock ctor to have unified code here.
Anyway since current solution solves the issue we can refactor in follow-up PR

@dmitry-gorokhov dmitry-gorokhov merged commit 6246fb0 into openvinotoolkit:master Dec 19, 2023
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin Code Freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants