Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GNA] Properly obtain all subsequent layers for memory layer connection #21602

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[GNA] Properly obtain all subsequent layers for memory layer connection #21602

merged 1 commit into from
Dec 13, 2023

Conversation

tadamowicz
Copy link
Contributor

Details:

  • Properly obtain all subsequent layers to prevent the memory layer from being disconnected

Tickets:

  • 146003

@tadamowicz tadamowicz requested a review from a team as a code owner December 12, 2023 12:38
@github-actions github-actions bot added the category: GNA OpenVINO GNA plugin label Dec 12, 2023
@tadamowicz tadamowicz force-pushed the Properly-obtain-all-subsequent-layers-for-memory-layer-connection branch from 656ecad to fd513ae Compare December 12, 2023 13:27
@tadamowicz tadamowicz enabled auto-merge (squash) December 12, 2023 13:45
marcinkusm
marcinkusm reviewed Dec 13, 2023
View reviewed changes
src/plugins/intel_gna/src/gna_graph_compiler.cpp
continue;
}
auto nextLayer = CNNNetGetNextLayerSkipCertain(layer, 0, j, isNonFunctional);
auto isNonFunctional = [](CNNLayerPtr l) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto isNonFunctional = [](CNNLayerPtr l) {
auto is_non_functional = [](CNNLayerPtr l) {

marcinkusm
marcinkusm reviewed Dec 13, 2023
View reviewed changes
src/plugins/intel_gna/src/gna_graph_compiler.cpp
continue;
}
auto nextLayer = CNNNetGetNextLayerSkipCertain(layer, 0, j, isNonFunctional);
auto isNonFunctional = [](CNNLayerPtr l) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found around 17 places in the code where such lambda is created, maybe it would be good to create such method?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I'm wondering if it makes sense to refactor at this moment, especially since we're about to introduce ngraph API here soon.

@tadamowicz tadamowicz merged commit 9fe38f1 into openvinotoolkit:master Dec 13, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinkacprzak marcinkacprzak marcinkacprzak approved these changes

@marcinkusm marcinkusm marcinkusm approved these changes

Assignees
No one assigned
Labels
category: GNA OpenVINO GNA plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tadamowicz @marcinkusm @marcinkacprzak