Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU tests] migrate single layer test cases to be API 2.0 - part 1 #21420

Conversation

riverlijunjie
Copy link
Contributor

Details:

  • CPU tests: migrate single layer test cases to be API 2.0 - part 1
  • ...

Tickets:

  • ticket-id

@riverlijunjie riverlijunjie requested review from a team as code owners December 1, 2023 09:28
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Dec 1, 2023
@riverlijunjie riverlijunjie force-pushed the river/cpu_tests_single_layer_part_1 branch from fa5547d to 11f4b95 Compare December 1, 2023 09:53
@riverlijunjie riverlijunjie force-pushed the river/cpu_tests_single_layer_part_1 branch from 11f4b95 to a3754d7 Compare December 1, 2023 13:26
@riverlijunjie riverlijunjie requested review from a team as code owners December 5, 2023 10:45
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Dec 5, 2023
@github-actions github-actions bot removed the category: IE Tests OpenVINO Test: plugins and common label Dec 6, 2023
@@ -3,18 +3,18 @@
//

#include "eltwise.hpp"

#include "common_test_utils/node_builders/eltwise.hpp"
#include "cpp_interfaces/interface/ie_internal_plugin_config.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it should not be used any more, I forgot deleting it, will do in next PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is done in PR: #21538

InferenceEngine::PluginConfigInternalParams::DISABLE});
}
if (enforceSnippets) {
configuration.insert({"SNIPPETS_MODE", "IGNORE_CALLBACK"});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use ov::intel_cpu::snippets_mode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ov::intel_cpu::snippets_mode is cpu plugin internal property, seems we cannot use it in test code. Is there any method to use it out of cpu plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is solved by PR:#21549

Copy link
Contributor

@vurusovs vurusovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, address comments in next PR

@vurusovs vurusovs merged commit 23424ab into openvinotoolkit:master Dec 7, 2023
68 checks passed
akuporos pushed a commit to akuporos/openvino that referenced this pull request Dec 8, 2023
…penvinotoolkit#21420)

* [CPU tests] migrate single layer test cases to be API 2.0 - part 1

* Remove LayerTestsDefinitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants