[PT FE] [ONNX FE] Partially upcast random_normal to f32 #21400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-esir
force-pushed
the
upcast_randn_to_f32
branch
2 times, most recently
from
5e6eda3 to
ed857e9
Compare
pavel-esir
changed the title
pavel-esir
commented
Nov 30, 2023
pavel-esir
commented
Nov 30, 2023
pavel-esir
changed the title
pavel-esir
changed the title
|
Could you add test for this? |
|
Some existing tests are failing. Wil fix this |
pavel-esir
force-pushed
the
upcast_randn_to_f32
branch
from
392982c to
e306867
Compare
|
@pavel-esir should we trigger any performance validation for this to check the potential regression? |
pavel-esir
commented
Dec 1, 2023
pavel-esir
commented
Dec 1, 2023
I think it's not necessary. These changes are very safe. RandomUniform and Logs are very computationally lightweight, compared to Convolutions, MatMuls. I took a look to execution graph and Log/RandomUniform both take ~2 microsecs, while Conv ~320 microsecs. |
gkrivor
approved these changes
Dec 1, 2023
github-actions
bot
added
category: CPU
…cast_randn_to_f32
Upcast randn to f32
mvafin
reviewed
Dec 6, 2023
vurusovs
previously requested changes
Dec 6, 2023
|
|
||
| #pragma once | ||
|
|
||
| #include "ngraph/output_vector.hpp" |
There was a problem hiding this comment.
please, avoid use of legacy API
There was a problem hiding this comment.
will fix this in a separate PR
ilya-lavrenov
approved these changes
Dec 7, 2023
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Dec 8, 2023
…kit#21400) * upcast randn to fp32 * style fix * corrected tests * add layer tests with statistics * style-fix * move make_random_normal to cmmmon * style-fix * added randn layer tests; updated CMakeLists.txt * moved to inline * fix problem with _USE_MATH_DEFINES on Win * pass NodeRegistry as reference; some other minor corrections * adjust thresholds to avoid sporadicity * move random_normal_helper and hide from public api * fix install * fix install: 2nd try * Frontend common * remove last frontend_common::static * build fix * try to fix mock1 build: 2nd attempt * try to fix mock1 build: 3rd attempt * Update src/core/tests/CMakeLists.txt * Fixed build: attemp 2 * Update src/plugins/intel_cpu/tests/unit/CMakeLists.txt * Update CMakeLists.txt --------- Co-authored-by: Ilya Lavrenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: