Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core]Migrate Gathers operators to new API #21390

Merged
merged 8 commits into from
Dec 6, 2023
Merged

[core]Migrate Gathers operators to new API #21390

merged 8 commits into from
Dec 6, 2023

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Nov 30, 2023

Details:

  • Migrate Gathers operators to new API, remove old includes, functions, namespaces.
  • Refactor to reduce bin-size
  • Minor refactor reference implementation to remove redundant code.

Tickets:

@praasz praasz requested a review from a team as a code owner November 30, 2023 10:00
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings labels Nov 30, 2023
t-jankowski
t-jankowski approved these changes Nov 30, 2023
View reviewed changes
src/core/src/op/gather.cpp Outdated Show resolved Hide resolved
@praasz praasz requested review from a team as code owners December 1, 2023 06:04
@praasz praasz requested review from akuporos, p-wysocki and mvafin and removed request for a team December 1, 2023 06:04
@github-actions github-actions bot removed category: AUTO BATCH OpenVINO Auto Batch plugin github_actions Pull requests that update GitHub Actions code category: PyTorch FE OpenVINO PyTorch Frontend labels Dec 1, 2023
@praasz praasz removed request for a team, akuporos, p-wysocki, mvafin and mmikolajcz December 1, 2023 06:15
@vurusovs vurusovs merged commit 635f5d3 into openvinotoolkit:master Dec 6, 2023
73 checks passed
@praasz praasz deleted the api-2.0/migrate-gather-op-to-new-api branch December 7, 2023 05:18
akuporos pushed a commit to akuporos/openvino that referenced this pull request Dec 8, 2023
@praasz @akuporos
[core]Migrate Gathers operators to new API (openvinotoolkit#21390)
a8aee30 
* Migrate Gather operators to new API

* Remove redundant code form reference

* Use IF_TYPE_OF macro

* Remove unused include

* Use common utils in gather base

* Fix normalize after merge issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vurusovs vurusovs vurusovs left review comments

@t-jankowski t-jankowski t-jankowski approved these changes

Assignees

@vurusovs vurusovs

@t-jankowski t-jankowski

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praasz @vurusovs @t-jankowski