Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check to avoid IR generation in case of wrong input shape #2127

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

sadolini
Copy link
Contributor

@sadolini sadolini commented Sep 8, 2020

Description: added check to avoid IR generation in case of wrong input shape

JIRA: 35684

Code:

  • Comments NA too simple change
  • Code style (PEP8)
  • Transformation generates reshape-able IR NA no new transformations
  • Transformation preserves original framework node names NA no new transformations

Validation:

  • Unit tests
  • Framework operation tests NA no new operations
  • Transformation tests NA no new transformations
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py NA change covered unit test
  • Model Optimizer IR Reader check NA no new operations

Documentation:

  • Supported frameworks operations list NA no new operations
  • Supported public models list NA no new models
  • New operations specification NA no new operations
  • Guide on how to convert the public model NA no new models
  • User guide update NA nothing new for user

@sadolini sadolini added bug Something isn't working category: MO Model Optimizer labels Sep 8, 2020
@sadolini sadolini requested review from lazarevevgeny and a team September 8, 2020 12:34
@sadolini sadolini requested a review from a team as a code owner September 9, 2020 06:43
@sadolini sadolini requested review from a team September 9, 2020 06:43
@sadolini sadolini removed request for a team September 9, 2020 13:21
@sadolini sadolini marked this pull request as draft September 9, 2020 13:26
@sadolini sadolini marked this pull request as ready for review September 10, 2020 13:54
model-optimizer/mo/ops/pooling.py Outdated Show resolved Hide resolved
model-optimizer/mo/ops/pooling.py Outdated Show resolved Hide resolved
model-optimizer/mo/ops/convolution.py Outdated Show resolved Hide resolved
@lazarevevgeny lazarevevgeny merged commit cdedc4a into openvinotoolkit:master Sep 16, 2020
@sadolini sadolini deleted the bugfix/35684 branch December 14, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants