[OVC] Fixed error in --output_model param. #20969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkazants
reviewed
Nov 9, 2023
rkazants
reviewed
Nov 9, 2023
rkazants
reviewed
Nov 13, 2023
rkazants
approved these changes
Nov 15, 2023
byungilm
pushed a commit
to byungilm/openvino
that referenced
this pull request
Nov 17, 2023
* Fixed error in get_model_name_from_args(), added tests. * Corrected output_model description. * Corrected test.
allnes
pushed a commit
to allnes/openvino
that referenced
this pull request
Nov 23, 2023
* Fixed error in get_model_name_from_args(), added tests. * Corrected output_model description. * Corrected test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause analysis:
If non-existing directory is set in --output_model, then OVC generates a model with empty name ".xml".
This happens due to error in get_model_name_from_args(), that treats non-existing as not a directory, which is wrong.
Solution:
Check not only os.path.isdir(argv.output_model), which checks that path existing directory, but also if path ends with separator which means it is non-existing output directory.
Also the logic was also corrected to not set synthetic "model.xml" name in any case. If we cannot derive original name (this can happen only if original saved model is located in root directory) and "--output_model" was not specified we should raise error.
Ticket: -
Code:
Validation:
Documentation: