Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] [GHA] Fix openvino.test_utils imports for Mac and Win Python unittests #20786

Conversation

akashchi
Copy link
Contributor

Tickets:

  • 123806

@akashchi akashchi added category: CI OpenVINO public CI WIP work in progress github_actions Pull requests that update GitHub Actions code labels Oct 31, 2023
@akashchi akashchi added this to the 2023.3 milestone Oct 31, 2023
.github/workflows/mac.yml Outdated Show resolved Hide resolved
Comment on lines 646 to 647
# Used for 'test_utils' installed in '<test_package>/python/openvino/test_utils'
export PYTHONPATH=${{ env.INSTALL_TEST_DIR }}/python/openvino/test_utils:$PYTHONPATH
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use test_utils from the test package or from the installed OV wheels?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed OV wheels contain product part of OpenVINO and don't contain any test utils.
So, we need to use it from test package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are test_utils even in the wheels?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no test_utils module in wheel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, did not update the page after the first comment, thanks for the clarification.

@akashchi
Copy link
Contributor Author

akashchi commented Oct 31, 2023

The previously failing tests with test_utils imports are passing on Mac and Win. I've removed triggers for them as they were. This PR contains the changes from the approved universal setup-python action PR.

@akashchi akashchi marked this pull request as ready for review October 31, 2023 18:42
@akashchi akashchi requested a review from a team as a code owner October 31, 2023 18:42
@akashchi akashchi removed the WIP work in progress label Oct 31, 2023
@ilya-lavrenov ilya-lavrenov merged commit 03f23ae into openvinotoolkit:master Nov 1, 2023
30 checks passed
alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
…nittests (openvinotoolkit#20786)

* add platform-agnostic setup python action

* use specific version

* rm debug message, checkout action

* correct path

* add checkout of the action, correct paths

* correct path; enclose into brackets

* transfer linux pipelines to local setup-python action

* transfer pipelines

* use newer version

* account for fedora, add missing cache path

* correct name

* use 3.9 for fedora

* rm python install from fedora

* mv fetch and setup together, set pip_cache_dir

* correct order

* rm triggers

* add missing pythonpaths

* correct path

* add one more pythonpath

* add paths to ov package libs

* Revert "add paths to ov package libs"

This reverts commit a775881.
allnes pushed a commit to allnes/openvino that referenced this pull request Nov 23, 2023
…nittests (openvinotoolkit#20786)

* add platform-agnostic setup python action

* use specific version

* rm debug message, checkout action

* correct path

* add checkout of the action, correct paths

* correct path; enclose into brackets

* transfer linux pipelines to local setup-python action

* transfer pipelines

* use newer version

* account for fedora, add missing cache path

* correct name

* use 3.9 for fedora

* rm python install from fedora

* mv fetch and setup together, set pip_cache_dir

* correct order

* rm triggers

* add missing pythonpaths

* correct path

* add one more pythonpath

* add paths to ov package libs

* Revert "add paths to ov package libs"

This reverts commit a775881.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants