Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range, RDFT, RandormUniform, ReduceOps layer tests to API2.0 #20692

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

vurusovs
Copy link
Contributor

No description provided.

@vurusovs vurusovs requested review from a team as code owners October 25, 2023 12:39
@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin category: CPU OpenVINO CPU plugin labels Oct 25, 2023
@vurusovs vurusovs force-pushed the vu/tests_to_api2_0_3 branch from 32cc69c to 34b1621 Compare October 25, 2023 12:42
@vurusovs vurusovs force-pushed the vu/tests_to_api2_0_3 branch from 34b1621 to fc72b67 Compare October 25, 2023 12:42
@@ -117,7 +117,7 @@ static std::map<ov::NodeTypeInfo, std::vector<std::vector<InputGenerateData>>> i
{ ov::op::v1::FloorMod::get_type_info_static(), {{{2, 4}}, {{2, 2, 128}}} },
{ ov::op::v1::Mod::get_type_info_static(), {{{2, 4}}, {{2, 2, 128}}} },
{ ov::op::v1::ReduceMax::get_type_info_static(), {{{0, 5}}, {{-5, 5, 1000}}} },
{ ov::op::v1::ReduceMean::get_type_info_static(), {{{0, 5}}, {{0, 5, 1000}}} },
{ ov::op::v1::ReduceMean::get_type_info_static(), {{{0, 5, 1000}}, {{0, 5, 1000}}} },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iefode without the change ReduceOpsLayerTest with Mean op type fails on integral types

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what is the values were in original test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iefode 0, 5, 1000 for all types (real and integral) were in original test. With 0, 5 only integral cases are failing in new tests

@vurusovs vurusovs force-pushed the vu/tests_to_api2_0_3 branch from fc72b67 to 9ee28f7 Compare October 25, 2023 13:08
@@ -117,7 +117,7 @@ static std::map<ov::NodeTypeInfo, std::vector<std::vector<InputGenerateData>>> i
{ ov::op::v1::FloorMod::get_type_info_static(), {{{2, 4}}, {{2, 2, 128}}} },
{ ov::op::v1::Mod::get_type_info_static(), {{{2, 4}}, {{2, 2, 128}}} },
{ ov::op::v1::ReduceMax::get_type_info_static(), {{{0, 5}}, {{-5, 5, 1000}}} },
{ ov::op::v1::ReduceMean::get_type_info_static(), {{{0, 5}}, {{0, 5, 1000}}} },
{ ov::op::v1::ReduceMean::get_type_info_static(), {{{0, 5, 1000}}, {{0, 5, 1000}}} },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what is the values were in original test?

function = std::make_shared<ov::Model>(reduce->outputs(), ov::ParameterVector{param}, "Reduce");
}

void ReduceOpsLayerWithSpecificInputTest::generate_inputs(const std::vector<ov::Shape>& targetInputStaticShapes) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to basic generator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, there is some specific use case (not for common use in other tests), so I ported it same way

@vurusovs vurusovs merged commit d532d14 into openvinotoolkit:master Oct 26, 2023
34 checks passed
@vurusovs
Copy link
Contributor Author

ie_tests_cpu_macos_arm64_release has passed

alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
…penvinotoolkit#20692)

* `Range` to API2.0

* `RDFTLayerTest` to API2.0

* `RandomUniformLayerTest` to API2.0

* `ReduceOpsLayerTest` to API2.0
allnes pushed a commit to allnes/openvino that referenced this pull request Nov 23, 2023
…penvinotoolkit#20692)

* `Range` to API2.0

* `RDFTLayerTest` to API2.0

* `RandomUniformLayerTest` to API2.0

* `ReduceOpsLayerTest` to API2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants