Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] [GHA] Introduce macOS ARM64 as a matrix parameter in the macOS pipeline #20363

Merged

Conversation

akashchi
Copy link
Contributor

Tickets:

  • 122475

@akashchi akashchi added category: CI OpenVINO public CI WIP work in progress github_actions Pull requests that update GitHub Actions code labels Oct 10, 2023
@akashchi akashchi added this to the 2023.2 milestone Oct 10, 2023
@akashchi akashchi requested a review from a team as a code owner October 10, 2023 13:36
Comment on lines 112 to 113
# TODO: Uncomment
# save: ${{ github.ref_name == 'master' && 'true' || 'false' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reminder

@ilya-lavrenov ilya-lavrenov requested a review from a team as a code owner October 10, 2023 23:03
@ilya-lavrenov ilya-lavrenov requested review from akuporos and artanokhov and removed request for a team October 10, 2023 23:03
@github-actions github-actions bot added category: tools OpenVINO C++ / Python tools category: dependency_changes Pull requests that update a dependency file category: packaging OpenVINO packaging / distribution labels Oct 10, 2023
@akashchi
Copy link
Contributor Author

Seems like there are a couple more failings after merging master, I will get to skipping them shortly.

.github/workflows/mac.yml Outdated Show resolved Hide resolved
.github/workflows/mac.yml Outdated Show resolved Hide resolved
@akashchi akashchi requested a review from a team as a code owner October 16, 2023 15:10
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Oct 16, 2023
@akashchi akashchi requested a review from a team as a code owner October 19, 2023 11:42
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Oct 19, 2023
@github-actions github-actions bot added the category: TFL FE OpenVINO TensorFlow Lite FrontEnd label Oct 20, 2023
@akashchi
Copy link
Contributor Author

The pipelines are passing: https://github.com/openvinotoolkit/openvino/actions/runs/6610350804?pr=20363. I've removed the PR and post-commit triggers and added a nightly trigger as it is in the Windows pipeline as ARM Macs are even pricier than x86_64 Macs.

@ilya-lavrenov ilya-lavrenov merged commit b67cff7 into openvinotoolkit:master Oct 23, 2023
32 of 37 checks passed
@ilya-lavrenov ilya-lavrenov removed the WIP work in progress label Oct 23, 2023
alvoron pushed a commit to alvoron/openvino that referenced this pull request Oct 24, 2023
…ipeline (openvinotoolkit#20363)

* add m1 mac pipelines as a matrix parameter

* Update mac.yml

disable java_api because of macos arm64 - Java is not available on macOS arm64 runners

* Update mac.yml

added always condition for all tests

* Update mac.yml

* Update mac.yml

* Update mac.yml

* Update setup.py

temp commit

* Update tools/openvino_dev/setup.py

* use matrix for var

* add mxnet to extras only for x86_64

* skip failing tests

* use xfail for Python tests; add missing filter for transformations tests

* skip CPU func tests on x86_64 mac; skip some tests from CPU func tests on arm mac

* Update mac.yml

* skip tests on mac arm

* skip tests on darwin; apply review

* add more skips for python and c++ tests

* skip tf tests

* skip more tf tests; skip more Python UT stages

* rm alwayses, rm triggers, add nightly trigger

---------

Co-authored-by: Ilya Lavrenov <[email protected]>
alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
…ipeline (openvinotoolkit#20363)

* add m1 mac pipelines as a matrix parameter

* Update mac.yml

disable java_api because of macos arm64 - Java is not available on macOS arm64 runners

* Update mac.yml

added always condition for all tests

* Update mac.yml

* Update mac.yml

* Update mac.yml

* Update setup.py

temp commit

* Update tools/openvino_dev/setup.py

* use matrix for var

* add mxnet to extras only for x86_64

* skip failing tests

* use xfail for Python tests; add missing filter for transformations tests

* skip CPU func tests on x86_64 mac; skip some tests from CPU func tests on arm mac

* Update mac.yml

* skip tests on mac arm

* skip tests on darwin; apply review

* add more skips for python and c++ tests

* skip tf tests

* skip more tf tests; skip more Python UT stages

* rm alwayses, rm triggers, add nightly trigger

---------

Co-authored-by: Ilya Lavrenov <[email protected]>
allnes pushed a commit to allnes/openvino that referenced this pull request Nov 23, 2023
…ipeline (openvinotoolkit#20363)

* add m1 mac pipelines as a matrix parameter

* Update mac.yml

disable java_api because of macos arm64 - Java is not available on macOS arm64 runners

* Update mac.yml

added always condition for all tests

* Update mac.yml

* Update mac.yml

* Update mac.yml

* Update setup.py

temp commit

* Update tools/openvino_dev/setup.py

* use matrix for var

* add mxnet to extras only for x86_64

* skip failing tests

* use xfail for Python tests; add missing filter for transformations tests

* skip CPU func tests on x86_64 mac; skip some tests from CPU func tests on arm mac

* Update mac.yml

* skip tests on mac arm

* skip tests on darwin; apply review

* add more skips for python and c++ tests

* skip tf tests

* skip more tf tests; skip more Python UT stages

* rm alwayses, rm triggers, add nightly trigger

---------

Co-authored-by: Ilya Lavrenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CI OpenVINO public CI category: ONNX FE OpenVINO ONNX FrontEnd category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants