Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONFORMANCE][TOOLS] Repeat pattern extractor API #20293

Merged
merged 9 commits into from
Oct 12, 2023
Merged

[CONFORMANCE][TOOLS] Repeat pattern extractor API #20293

merged 9 commits into from
Oct 12, 2023

Conversation

iefode
Copy link
Contributor

@iefode iefode commented Oct 6, 2023 •
edited
Loading

Details:

  • What's done:
  • RepeatPattern extractor was extended by new API to extract pattern with links to original nodes
  • Model_comparator was extracted to separated entity in subgraphs_dumper tool
  • Boolean flags were move directly to an extractor (repeat_extraction, extract_body and etc)
  • Strict graph comparation by shape was added
  • Redefinition of model comparation coefficient was added
  • What's next:
  • To clean up dependency on test_utils from subgraphs_dumper
  • To improve the algo extractor and defines new extraction criteria
  • Architecture diagram:
    Диаграмма без названия drawio

Tickets:

@iefode iefode requested review from a team as code owners October 6, 2023 21:21
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Oct 6, 2023
@iefode iefode changed the title Prepare API [CONFORMANCE][TOOLS] Repeat pattern extractor API Oct 6, 2023
@iefode iefode self-assigned this Oct 11, 2023
@iefode iefode modified the milestones: 2022.3, 2023.2 Oct 11, 2023
iefode
iefode commented Oct 11, 2023
View reviewed changes
.../functional/plugin/conformance/subgraphs_dumper/include/matchers/subgraph/repeat_pattern.hpp
bool is_copy_constants = true) override;
using PatternBorders = std::pair<InputVector, OutputVector>;

std::vector<std::vector<PatternBorders>>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jane-intel @slyalin Please look to the extended pattern API. Please approve if LGTU

jane-intel
jane-intel approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@jane-intel jane-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this API suitable for my needs. Thank you!

@iefode iefode requested a review from a team as a code owner October 11, 2023 18:26
@iefode iefode requested review from zKulesza and removed request for a team October 11, 2023 18:26
@github-actions github-actions bot added the category: docs OpenVINO documentation label Oct 11, 2023
@iefode iefode enabled auto-merge (squash) October 11, 2023 18:27
@iefode iefode merged commit 74690d0 into openvinotoolkit:master Oct 12, 2023
23 checks passed
@iefode iefode deleted the loopinizer_api branch October 12, 2023 17:06
alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
@iefode @alvoron
[CONFORMANCE][TOOLS] Repeat pattern extractor API (openvinotoolkit#20293
8f6948c 
)

* Prepare API

* Refactor api

* Move model comparation to separate component

* Cover by tests

* Move align_in_info to utils

* Change arch diagram
allnes pushed a commit to allnes/openvino that referenced this pull request Nov 23, 2023
@iefode @allnes
[CONFORMANCE][TOOLS] Repeat pattern extractor API (openvinotoolkit#20293
8158e8c 
)

* Prepare API

* Refactor api

* Move model comparation to separate component

* Cover by tests

* Move align_in_info to utils

* Change arch diagram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jane-intel jane-intel jane-intel approved these changes

@slyalin slyalin Awaiting requested review from slyalin

@andrei-kochin andrei-kochin Awaiting requested review from andrei-kochin

@zKulesza zKulesza Awaiting requested review from zKulesza zKulesza is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

Assignees

@iefode iefode

Labels
category: docs OpenVINO documentation category: IE Tests OpenVINO Test: plugins and common conformance
Projects
None yet
Milestone
2023.2
Development

Successfully merging this pull request may close these issues.
2 participants
@iefode @jane-intel