[PyOV] Propagate errors on imports from runtime module #20273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: MO
ilya-lavrenov
approved these changes
Oct 5, 2023
rkazants
reviewed
Oct 6, 2023
| from openvino.runtime import serialize | ||
| from openvino.runtime import shutdown | ||
| from openvino.runtime import tensor_from_file | ||
| from openvino.runtime import save_model |
There was a problem hiding this comment.
Should we have convert_model here?
There was a problem hiding this comment.
it's below in a separate try / catch block.
This is because if I use only python API from build folder, OVC is not there
p-wysocki
approved these changes
Oct 6, 2023
| "${OpenVINOPython_SOURCE_DIR}/src/openvino/__init__.py" | ||
| "${OpenVINOPython_SOURCE_DIR}/src/compatibility/openvino/__init__.py" | ||
| "${OpenVINO_SOURCE_DIR}/tools/ovc/openvino/__init__.py" | ||
| "${OpenVINO_SOURCE_DIR}/tools/benchmark_tool/openvino/__init__.py") |
There was a problem hiding this comment.
do we need all these runtime copies at all?
maybe we need to keep only "${OpenVINOPython_SOURCE_DIR}/src/openvino/__init__.py" ? All other runtime modules cannot be used without OpenVINO anyway
jiwaszki
force-pushed
the
jiwaszki/adjust_init_files
branch
from
1132192 to
f97a42d
Compare
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Nov 6, 2023
…it#20273) Co-authored-by: Michal Lukaszewski <[email protected]>
allnes
pushed a commit
to allnes/openvino
that referenced
this pull request
Nov 23, 2023
…it#20273) Co-authored-by: Michal Lukaszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
openvino/__init__.pywith try-catch solution. This also allow to use package fromPYTHONPATHwhen onlyopenvino-devis defined for legacy usage.__init__.pyfiles is decoupled from openvino-dev's ones.Tickets: