Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmentation fault when running test_get_runtime_model test #20163

Closed
wants to merge 2 commits into from
Closed

Segmentation fault when running test_get_runtime_model test #20163

wants to merge 2 commits into from

Conversation

siddhant-0707
Copy link
Contributor

@siddhant-0707 siddhant-0707 commented Sep 30, 2023 •
edited by ilya-lavrenov
Loading

Details:

  • fixes segfault as produced in issue
  • python 3.8.10

Tickets:

It appears that the segfault is fixed when core.import_model() is called before get_runtime_model()

@siddhant-0707 siddhant-0707 requested a review from a team as a code owner September 30, 2023 15:11
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Sep 30, 2023
@siddhant-0707
Copy link
Contributor Author

siddhant-0707 commented Sep 30, 2023 •
edited
Loading

test_get_runtime_model passes when not run separately, if we run test_export_import before it. This is because test_export_import uses core.import_model(). By including suggested code it passes both separately and while running all tests together. Some other fix may be required to solve the issue as it seems to be linked to some internals being changed by import_model()

ilya-lavrenov
ilya-lavrenov reviewed Sep 30, 2023
View reviewed changes
src/bindings/python/tests/test_runtime/test_compiled_model.py

core = Core()
user_stream = compiled_model.export_model()
core.import_model(user_stream, device)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's totally unclear why do we need to export / import model to resolve a segfault

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddhant-0707 mentioned that it is unclear why. However, my best bet would be creating actual core = Core() that is somehow affecting internals. Would you be able to test it out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiled_model (returned by generate_relu_compiled_model) is expected to hold some internal to prolong its live time and ensure correct destruction.
But if it's 100% reproducible, it can be debugged with dbg. @siddhant-0707 could you please try to collect debugger logs?

@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiwaszki jiwaszki jiwaszki left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

Assignees
No one assigned
Labels
category: Python API OpenVINO Python bindings Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when running test_get_runtime_model test
3 participants
@siddhant-0707 @ilya-lavrenov @jiwaszki