Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Commit slider's handling of non-decodable characters #20149

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Improve Commit slider's handling of non-decodable characters #20149

merged 1 commit into from
Oct 13, 2023

Conversation

IvanNovoselov
Copy link
Contributor

Details:

  • Commit slider could have troubles writing to stdout non-unicode characters that it failed to decode. This patch fixes this behavior, so the non-decodable characters will be replaced with "?" now.

Tickets:

  • -

@IvanNovoselov IvanNovoselov requested review from a team as code owners September 29, 2023 10:58
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Sep 29, 2023
yury-intel
yury-intel approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@yury-intel yury-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@IvanNovoselov
Copy link
Contributor Author

@dmitry-gorokhov please take a look

@dmitry-gorokhov dmitry-gorokhov merged commit 157041e into openvinotoolkit:master Oct 13, 2023
31 checks passed
alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
@IvanNovoselov @alvoron
[CPU] Improve Commit slider's handling of non-decodable characters (o…
d453e7a 
…penvinotoolkit#20149)
allnes pushed a commit to allnes/openvino that referenced this pull request Nov 23, 2023
@IvanNovoselov @allnes
[CPU] Improve Commit slider's handling of non-decodable characters (o…
41658a3 
…penvinotoolkit#20149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-intel yury-intel yury-intel approved these changes

@dmitry-gorokhov dmitry-gorokhov Awaiting requested review from dmitry-gorokhov

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanNovoselov @yury-intel @dmitry-gorokhov