[C API] support string size for char pointer #19931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyachur
reviewed
Sep 19, 2023
| * @return Status code of the operation: OK(0) for success. | ||
| */ | ||
| OPENVINO_C_API(ov_status_e) | ||
| ov_core_read_model_from_memory_with_size(const ov_core_t* core, |
There was a problem hiding this comment.
Maybe we can come up the better name... For example: ov_core_read_model_from_memory_buffer
There was a problem hiding this comment.
Also we can deprecate old method, because these methods provide the same functionality
There was a problem hiding this comment.
But if deprecate old method maybe lead to some compatibility problem if this API has been used by user application.
There was a problem hiding this comment.
Yes in this case user will get a deprecation warning, but it is a normal process and without it we cannot change or remove legacy API. I don't talk about deletion of legacy method immediately, only about the deprecation and removing later.
From my point of view two methods will confuse users...
ilyachur
approved these changes
Oct 2, 2023
ilya-lavrenov
approved these changes
Oct 2, 2023
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Nov 6, 2023
* [C API] support string size for char pointer * rename function name * Add deprecated flag * Add macro to ignore deprecated * Fix build error in windows --------- Co-authored-by: Ilya Churaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: