Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONFORMANCE][SUBGRAPHS DUMPER] Rework subgraphs_dumper graphs extraction algo feedback by plugins #19669

Merged
merged 32 commits into from
Oct 4, 2023
Merged

[CONFORMANCE][SUBGRAPHS DUMPER] Rework subgraphs_dumper graphs extraction algo feedback by plugins #19669

merged 32 commits into from
Oct 4, 2023

Conversation

iefode
Copy link
Contributor

@iefode iefode commented Sep 7, 2023 •
edited
Loading

Details:

  • Subgraph extraction algorithms:
  • Exclude constants in case large models. Constants will be replaced by constants in case model binary size > 50% RAM
  • Subgraphs will be matched in case 90% ops are the same. (Input/Output op type should be same to match ops)
  • Secondary repeat pattern extraction in case large extracted subgraphs (>20 operations)
  • Exclude patterns from graph case in case one pattern is part of other one. In this case we will store large graph and extend their meta info
  • set device name for fused_name algo by command-line arg
  • Model processing:
  • Static models will be processed twice: original IR and after constant_folding transformation pass
  • Meta info update:
  • Input_info is extended by shape ranges as min_shape and max_shape
  • Fixed issues:
  • replace get_default_output() in graph recover for multioutput node cases
  • correct enabling to read local_cache for subgraphs
  • Hashing algo:
  • Change hashing algo to check const/parameters in meta info
  • Add subgraphs to count expected relative passrates
  • Serialization:
  • separation static and dynamic subgraphs`
  • Cache serialization if not enough RAM

TODO:

  • To describe extraction algorithms in readme

Tickets:

@iefode iefode self-assigned this Sep 7, 2023
@iefode iefode requested review from a team as code owners September 7, 2023 08:29
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Sep 7, 2023
@iefode iefode changed the title [CONFORMANCE][SUBGRAPHS DUMPER] Change repeat pattern extractor to av… [CONFORMANCE][SUBGRAPHS DUMPER] Change repeat pattern extractor to avoid of duplications and reduce graphs size Sep 14, 2023
@iefode iefode requested review from a team as code owners September 18, 2023 16:35
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Sep 18, 2023
@github-actions github-actions bot removed the category: CPU OpenVINO CPU plugin label Sep 19, 2023
@iefode iefode removed request for a team September 19, 2023 11:04
@iefode iefode changed the title [CONFORMANCE][SUBGRAPHS DUMPER] Change repeat pattern extractor to avoid of duplications and reduce graphs size [CONFORMANCE][SUBGRAPHS DUMPER] Rework subgraphs_dumper graphs extraction algo feedback by plugins Sep 20, 2023
@iefode iefode enabled auto-merge (squash) September 26, 2023 08:38
@iefode iefode merged commit cdcbb1d into openvinotoolkit:master Oct 4, 2023
@iefode iefode deleted the subgraphs_feedback branch October 5, 2023 08:00
alvoron pushed a commit to alvoron/openvino that referenced this pull request Oct 5, 2023
@iefode @alvoron
[CONFORMANCE][SUBGRAPHS DUMPER] Rework subgraphs_dumper graphs extr…
e50528b 
…action algo feedback by plugins (openvinotoolkit#19669)

* [CONFORMANCE][SUBGRAPHS DUMPER] Change repeat pattern extractor to avoid duplications and reduce graphs size

* Small change

* temporary

* merge

* try to handle large models

* Fixes + tests

* Remove extra

* Exclude models after const folding in case dynamic modesl

* shapes to meta

* Fix tests

* Fix test + is_subgraph

* Fix issue with default output

* change hashing

* Check memory

* Hash algo

* correct modelsize check

* Log large models

* tmp disable fused_names extractor

* add device for fused_names

* remove extra

* fix vuild

* Disable fused_names extractor
alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
@iefode @alvoron
[CONFORMANCE][SUBGRAPHS DUMPER] Rework subgraphs_dumper graphs extr…
743b392 
…action algo feedback by plugins (openvinotoolkit#19669)

* [CONFORMANCE][SUBGRAPHS DUMPER] Change repeat pattern extractor to avoid duplications and reduce graphs size

* Small change

* temporary

* merge

* try to handle large models

* Fixes + tests

* Remove extra

* Exclude models after const folding in case dynamic modesl

* shapes to meta

* Fix tests

* Fix test + is_subgraph

* Fix issue with default output

* change hashing

* Check memory

* Hash algo

* correct modelsize check

* Log large models

* tmp disable fused_names extractor

* add device for fused_names

* remove extra

* fix vuild

* Disable fused_names extractor
allnes pushed a commit to allnes/openvino that referenced this pull request Nov 23, 2023
@iefode @allnes
[CONFORMANCE][SUBGRAPHS DUMPER] Rework subgraphs_dumper graphs extr…
e3846fe 
…action algo feedback by plugins (openvinotoolkit#19669)

* [CONFORMANCE][SUBGRAPHS DUMPER] Change repeat pattern extractor to avoid duplications and reduce graphs size

* Small change

* temporary

* merge

* try to handle large models

* Fixes + tests

* Remove extra

* Exclude models after const folding in case dynamic modesl

* shapes to meta

* Fix tests

* Fix test + is_subgraph

* Fix issue with default output

* change hashing

* Check memory

* Hash algo

* correct modelsize check

* Log large models

* tmp disable fused_names extractor

* add device for fused_names

* remove extra

* fix vuild

* Disable fused_names extractor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbalandi sbalandi sbalandi approved these changes

Assignees

@iefode iefode

Labels
category: IE Tests OpenVINO Test: plugins and common conformance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iefode @sbalandi