Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Improving code snippets for quantization #19479

Merged
merged 7 commits into from
Aug 30, 2023
Merged

[DOCS] Improving code snippets for quantization #19479

merged 7 commits into from
Aug 30, 2023

Conversation

sgolebiewski-intel
Copy link
Contributor

@sgolebiewski-intel sgolebiewski-intel commented Aug 29, 2023 •
edited
Loading

Improving code snippets for Quantize a Model section in the article
This PR addresses the following JIRA ticket: 111579

@sgolebiewski-intel sgolebiewski-intel requested a review from a team as a code owner August 29, 2023 13:03
@sgolebiewski-intel sgolebiewski-intel requested review from zKulesza and removed request for a team August 29, 2023 13:03
@github-actions github-actions bot added the category: docs OpenVINO documentation label Aug 29, 2023
alexsu52
alexsu52 requested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users, usually, copy code from examples and try to run it. Did you try to run code of your changes?

docs/optimization_guide/nncf/ptq/code/ptq_onnx.py Outdated Show resolved Hide resolved
docs/optimization_guide/nncf/ptq/code/ptq_openvino.py Outdated Show resolved Hide resolved
docs/optimization_guide/nncf/ptq/code/ptq_tensorflow.py Outdated Show resolved Hide resolved
docs/optimization_guide/nncf/ptq/code/ptq_torch.py Outdated Show resolved Hide resolved
alexsu52
alexsu52 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgolebiewski-intel sgolebiewski-intel enabled auto-merge (squash) August 30, 2023 09:15
@sgolebiewski-intel sgolebiewski-intel merged commit 87f6e34 into openvinotoolkit:master Aug 30, 2023
sgolebiewski-intel added a commit to sgolebiewski-intel/openvino that referenced this pull request Aug 30, 2023
@sgolebiewski-intel
improve-snippets
4290f7c 
Porting: openvinotoolkit#19479
@sgolebiewski-intel sgolebiewski-intel mentioned this pull request Aug 30, 2023
Merged
sgolebiewski-intel added a commit to sgolebiewski-intel/openvino that referenced this pull request Aug 30, 2023
@sgolebiewski-intel
improve-snippets
81d7166 
Porting: openvinotoolkit#19479
@sgolebiewski-intel sgolebiewski-intel mentioned this pull request Aug 30, 2023
Merged
sgolebiewski-intel added a commit that referenced this pull request Aug 30, 2023
@sgolebiewski-intel
improve-snippets (#19497)
ca98745 
Porting: #19479
sgolebiewski-intel added a commit that referenced this pull request Aug 30, 2023
@sgolebiewski-intel
improve-snippets (#19498)
fd519c7 
Porting: #19479
@sgolebiewski-intel sgolebiewski-intel deleted the CVS-111579-improve-code-snippets-for-quantization-for-master branch November 21, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zKulesza zKulesza zKulesza approved these changes

@alexsu52 alexsu52 alexsu52 approved these changes

@AlexKoff88 AlexKoff88 Awaiting requested review from AlexKoff88

Assignees
No one assigned
Labels
category: docs OpenVINO documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgolebiewski-intel @alexsu52 @zKulesza