Bump cython in cmake #19473
Merged
Bump cython in cmake #19473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: build
p-wysocki
requested review from
AlexKoff88 and
artanokhov
and removed request for
a team
github-actions
bot
added
the
category: dependency_changes
artanokhov
approved these changes
Aug 29, 2023
jiwaszki
approved these changes
Aug 29, 2023
This was referenced Aug 30, 2023
| RUN python3 -m venv ~/.venv | ||
| RUN . ~/.venv/bin/activate | ||
| RUN which python3 | ||
| RUN python3 -m pip install "cython>=3.0.0" --break-system-packages |
There was a problem hiding this comment.
looks like . ~/.venv/bin/activate does not work as you expected, otherwise --break-system-packages is not required.
There was a problem hiding this comment.
I'll create a cleanup PR today.
p-wysocki
added a commit
to p-wysocki/openvino
that referenced
this pull request
Sep 1, 2023
This reverts commit 35a1840.
ilya-lavrenov
added a commit
that referenced
this pull request
Sep 2, 2023
* Revert "Bump cython in cmake (#19473)" This reverts commit 35a1840. * Disable cmake check * Robust detection of Cython version (#19537) --------- Co-authored-by: Ilya Lavrenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build worked locally, let's see if it works in CI.