Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MO fusing activations #1942

Merged
merged 15 commits into from
Aug 27, 2020
Merged

MO fusing activations #1942

merged 15 commits into from
Aug 27, 2020

Conversation

lazarevevgeny
Copy link
Contributor

@lazarevevgeny lazarevevgeny commented Aug 26, 2020 •
edited
Loading

Description: Implemented fusing transformations for activation functions enabled in this release. These transformations are need in the MO so the POT can work properly (similar story as with GeLU)

JIRA: 36128 and several others

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR: N/A
  • Transformation preserves original framework node names: yes

Validation:

  • Unit tests: done
  • Framework operation tests: should have been done as part of other activity
  • Transformation tests: done
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py: model already exists
  • Model Optimizer IR Reader check: verified manually

Documentation:

  • Supported frameworks operations list: no new op enabled
  • Supported public models list: no new model enabled
  • New operations specification: no new op enabled
  • Guide on how to convert the public model: no new model enabled
  • User guide update: N/A

@lazarevevgeny lazarevevgeny marked this pull request as ready for review August 26, 2020 13:59
@lazarevevgeny lazarevevgeny requested a review from a team August 26, 2020 13:59
jane-intel
jane-intel previously approved these changes Aug 26, 2020
View reviewed changes
jane-intel
jane-intel reviewed Aug 26, 2020
View reviewed changes
Copy link
Contributor

@jane-intel jane-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if all our tests follow the approach I mentioned, but tests supposed to be applications without bugs themselves from my point of view. If you don't feel that way, please ignore the comment about tests.

model-optimizer/extensions/front/HSwish_fusing_test.py Outdated Show resolved Hide resolved
model-optimizer/extensions/front/Swish_fusion.py Outdated Show resolved Hide resolved
model-optimizer/extensions/front/Swish_fusion.py Outdated Show resolved Hide resolved
@jane-intel jane-intel dismissed their stale review August 26, 2020 17:55

new changes

@jane-intel jane-intel merged commit a4d90a0 into openvinotoolkit:master Aug 27, 2020
RomanZm pushed a commit to RomanZm/openvino that referenced this pull request Aug 28, 2020
@lazarevevgeny
MO fusing activations (openvinotoolkit#1942)
f27fb4a 
* Added HSwish operation

* Added HSwish fusing transformation

* Fixed BOM

* Added unit test for HSwish fusing transformation

* Fixed unit tests for transformations using 'build_graph_with_edge_attrs' function to build the graph

* Added fusion transformation for Swish operation

* Added fusing transformation for Softplus operation

* Added fusion transformation for Mish operation

* Added check for the node name in the unit tests

* Fixed Mish fusion pattern

* Updated Mish fusion transformation. Added unit test

* Updated HSwish fusing transformation

* Updated Swish fusion transformation and tests

* Fixed unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jane-intel jane-intel jane-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazarevevgeny @jane-intel