Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ MO ] Fix for remove_op_node_with_data_node #1934

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

jane-intel
Copy link
Contributor

@jane-intel jane-intel commented Aug 25, 2020

Description: Merge operation can have one input coming from input port #1. This caused an issue because remove_op_node_with_data_node used only #0 input which was missing

NOTE: It is reproducible without --static_shape key only because of lack of Merge operation testing variants. The issue is not connected to KSO/reshape.

JIRA: 37868

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests
  • Transformation tests
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list
  • Supported public models list
  • New operations specification
  • Guide on how to convert the public model
  • User guide update

@jane-intel jane-intel added bug Something isn't working category: MO Model Optimizer labels Aug 25, 2020
@jane-intel jane-intel added this to the 2021.1 milestone Aug 25, 2020
@jane-intel jane-intel requested review from lazarevevgeny and a team August 25, 2020 13:32
@jane-intel jane-intel merged commit c4920ef into openvinotoolkit:master Aug 25, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Aug 26, 2020
RomanZm pushed a commit to RomanZm/openvino that referenced this pull request Aug 28, 2020
@jane-intel jane-intel deleted the mo/jane/#37868 branch October 22, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants