Add support for ReduceL1 and ReduceL2 to ONNX Importer #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blesniewski
requested review from
postrational,
sdurawa,
ggalieroc-zz and
a team
blesniewski
force-pushed
the
use_new_reduce_ops_in_onnx_importer
branch
from
c8979c1 to
f51b3f8
Compare
ggalieroc-zz
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Looks good. Please verify why these 2 tests are still failing:
[gw11] [ 63%] PASSED tests/test_onnx/test_ops_reduction.py::test_reduce_l2[reduction_axes0]
[gw13] [ 65%] PASSED tests/test_onnx/test_ops_reduction.py::test_reduce_l1[reduction_axes0]
[gw11] [ 66%] PASSED tests/test_onnx/test_ops_reduction.py::test_reduce_l2[reduction_axes1]
[gw13] [ 67%] PASSED tests/test_onnx/test_ops_reduction.py::test_reduce_l1[reduction_axes1]
[gw11] [ 68%] PASSED tests/test_onnx/test_ops_reduction.py::test_reduce_l2[reduction_axes2]
[gw13] [ 68%] PASSED tests/test_onnx/test_ops_reduction.py::test_reduce_l1[reduction_axes2]
[gw13] [ 70%] XFAIL tests/test_onnx/test_ops_reduction.py::test_reduce_l1_default_axes
[gw11] [ 71%] XFAIL tests/test_onnx/test_ops_reduction.py::test_reduce_l2_default_axes
f51b3f8 to
4c5797a
Compare
added 2 commits
August 20, 2020 15:05
blesniewski
force-pushed
the
use_new_reduce_ops_in_onnx_importer
branch
from
4c5797a to
7d5e4b7
Compare
|
@openvinotoolkit/openvino-maintainers - I think this is ready for merging, the two tests mentioned before were also enabled |
postrational
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: