EliminatePad and PadFusion support Pad12 positive indexes #18278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evkotov
added
the
category: transformations
evkotov
force-pushed
the
pad12_pad_fusion
branch
from
f122040 to
ba86d3d
Compare
itikhono
reviewed
Jul 3, 2023
| @@ -96,14 +97,14 @@ pass::PadFusionAvgPool::PadFusionAvgPool() { | |||
| auto pads_end_pattern = pattern::wrap_type<opset5::Constant>(); | |||
| auto pad_value_pattern = pattern::any_input(); | |||
| auto pad_node_pattern = | |||
| pattern::wrap_type<opset5::Pad>({data_pattern, pads_begin_pattern, pads_end_pattern, pad_value_pattern}, | |||
| pattern::consumers_count(1)); | |||
| pattern::wrap_type<op::util::PadBase>({data_pattern, pads_begin_pattern, pads_end_pattern, pad_value_pattern}, | |||
There was a problem hiding this comment.
just a note, no changes from your side required: I hope the check on line 58 (pad_fusion.cpp) should already detect the negative pad values
There was a problem hiding this comment.
Thank you. I noticed that before PR creation
itikhono
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
PadFusionGroupConvolution, PadFusionGroupConvolutionBackpropData) Pad12 positive indexes
Tickets: