Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ov element type visitor #18189

Merged
merged 17 commits into from
Jul 6, 2023
Merged

Introduce ov element type visitor #18189

merged 17 commits into from
Jul 6, 2023

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Jun 22, 2023 •
edited
Loading

Details:

  • Simplify evaluate implementation and code code maintenance by automatic code generation over switch case and macro
  • Applied visitor reduce openvinolib.so by around 27 KiB (Ubuntu 20.04, gcc 9.4, release build no LTO).

Tickets:

N/A

@praasz praasz requested review from a team as code owners June 22, 2023 11:53
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin labels Jun 22, 2023
@praasz praasz requested a review from a team as a code owner June 23, 2023 12:24
@praasz praasz requested a review from t-jankowski June 23, 2023 13:20
@github-actions github-actions bot removed the category: CPU OpenVINO CPU plugin label Jun 26, 2023
@mlukasze
Copy link
Contributor

mlukasze commented Jul 6, 2023

@ilyachur & @mitruska could you review it, please?

ilyachur
ilyachur approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea LGTM

src/core/src/op/round.cpp Show resolved Hide resolved
@ilyachur ilyachur merged commit c1f26d1 into openvinotoolkit:master Jul 6, 2023
@ilyachur ilyachur added this to the 2023.1 milestone Jul 6, 2023
@praasz praasz deleted the feature/ov-element-type-for-each-visitor branch August 4, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-jankowski t-jankowski t-jankowski approved these changes

@ilyachur ilyachur ilyachur approved these changes

@tomdol tomdol Awaiting requested review from tomdol

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
2023.1
Development

Successfully merging this pull request may close these issues.
4 participants
@praasz @mlukasze @ilyachur @t-jankowski