Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] ONNX Unique tests failing on CPU #18100

Merged
merged 2 commits into from
Jul 5, 2023
Merged

[CPU] ONNX Unique tests failing on CPU #18100

merged 2 commits into from
Jul 5, 2023

Conversation

nshchego
Copy link
Contributor

Details:

  • Fix for invalid sorting in sliced case

Tickets:

  • 101008, 103964

@nshchego nshchego requested review from a team as code owners June 16, 2023 07:07
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jun 16, 2023
@tomdol
Copy link
Contributor

tomdol commented Jun 16, 2023

The ONNX tests got fixed by this PR so you need to enable them to make the ONNX CI pass. Please remove the usages of this xfail https://github.com/openvinotoolkit/openvino/blob/master/src/bindings/python/tests/test_onnx/test_backend.py#L199 and its definition because after your PR it does not apply to any test any more.

@dmitry-gorokhov dmitry-gorokhov added this to the 2023.1 milestone Jun 16, 2023
@dmitry-gorokhov
Copy link
Contributor

@antonvor Please review this PR

@nshchego nshchego force-pushed the cpu/unique_onnx_tests_fix branch from 77d14ef to df7c480 Compare June 16, 2023 12:04
@nshchego nshchego requested a review from a team as a code owner June 16, 2023 12:04
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Jun 16, 2023
@nshchego nshchego force-pushed the cpu/unique_onnx_tests_fix branch 2 times, most recently from 842e9da to da630a5 Compare June 19, 2023 06:20
@nshchego nshchego force-pushed the cpu/unique_onnx_tests_fix branch from da630a5 to 516f99e Compare July 4, 2023 18:29
@maxnick maxnick merged commit 886fd0d into openvinotoolkit:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxnick maxnick maxnick approved these changes

@antonvor antonvor antonvor approved these changes

Assignees

@antonvor antonvor

Labels
category: CPU OpenVINO CPU plugin category: Python API OpenVINO Python bindings
Projects
None yet
Milestone
2023.1
Development

Successfully merging this pull request may close these issues.
5 participants
@nshchego @tomdol @dmitry-gorokhov @antonvor @maxnick